Skip to content

Commit e959512

Browse files
ci: note ordering constraint on transitive patch step
Document that the transitive [patch.crates-io] step must run after the spec-shaking step, so the spec-shaking sed does not add an ignored features field to the patch entries.
1 parent 104dcf9 commit e959512

2 files changed

Lines changed: 8 additions & 0 deletions

File tree

.github/workflows/test-with-openzeppelin-stellar-contracts.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -96,6 +96,10 @@ jobs:
9696
# Add features field to path-patched entries without features
9797
sed -i '/soroban-sdk = {.*path = /{/features/!s| }|, features = ["experimental_spec_shaking_v2"] }|}' Cargo.toml
9898
99+
# This step must run *after* "Enable experimental_spec_shaking_v2": that step's
100+
# sed matches every `soroban-sdk = { ... path = ... }` line, so if the
101+
# [patch.crates-io] entries below already existed it would add a `features` field
102+
# to them, which Cargo ignores on patch entries and warns about.
99103
- name: Patch transitive crates.io dependencies
100104
working-directory: stellar-contracts
101105
run: |

.github/workflows/test-with-soroban-examples.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -112,6 +112,10 @@ jobs:
112112
sed -i '/soroban-sdk = {.*path = /{/features/!s| }|, features = ["experimental_spec_shaking_v2"] }|}' "$file"
113113
done
114114
115+
# This step must run *after* "Enable experimental_spec_shaking_v2": that step's
116+
# sed matches every `soroban-sdk = { ... path = ... }` line, so if the
117+
# [patch.crates-io] entries below already existed it would add a `features` field
118+
# to them, which Cargo ignores on patch entries and warns about.
115119
- name: Patch transitive crates.io dependencies
116120
run: |
117121
# Crates such as soroban-poseidon are pulled from crates.io and depend on

0 commit comments

Comments
 (0)