Adapt testsuite to fastdev

graydon · graydon · commit 85953cd4ead6 · 2026-07-16T23:32:55.000-07:00
diff --git a/common.mk b/common.mk
@@ -43,6 +43,10 @@ if ENABLE_NEXT_PROTOCOL_VERSION_UNSAFE_FOR_PRODUCTION
 AM_CPPFLAGS += -DENABLE_NEXT_PROTOCOL_VERSION_UNSAFE_FOR_PRODUCTION
 endif # ENABLE_NEXT_PROTOCOL_VERSION_UNSAFE_FOR_PRODUCTION
 
+if ENABLE_FASTDEV_UNSAFE_FOR_PRODUCTION
+AM_CPPFLAGS += -DENABLE_FASTDEV_UNSAFE_FOR_PRODUCTION
+endif # ENABLE_FASTDEV_UNSAFE_FOR_PRODUCTION
+
 if CAP_0083
 AM_CPPFLAGS += -DCAP_0083
 endif
diff --git a/src/herder/test/HerderTests.cpp b/src/herder/test/HerderTests.cpp
@@ -1042,7 +1042,15 @@ TEST_CASE("txset", "[herder][txset]")
 {
     SECTION("generalized tx set protocol")
     {
-        testTxSet(static_cast<uint32>(SOROBAN_PROTOCOL_VERSION));
+        uint32_t generalizedTxSetProtocolVersion =
+            static_cast<uint32>(SOROBAN_PROTOCOL_VERSION);
+#ifdef ENABLE_FASTDEV_UNSAFE_FOR_PRODUCTION
+        // Fastdev only links recent Soroban hosts, and this test just needs a
+        // generalized-txset-capable protocol.
+        generalizedTxSetProtocolVersion =
+            Config::CURRENT_LEDGER_PROTOCOL_VERSION - 1;
+#endif
+        testTxSet(generalizedTxSetProtocolVersion);
     }
     SECTION("protocol current")
     {
@@ -1450,6 +1458,12 @@ TEST_CASE("txset base fee", "[herder][txset]")
                            uint32_t expNotChargedAccounts = 0) {
         cfg.LEDGER_PROTOCOL_VERSION = protocolVersion;
         cfg.TESTING_UPGRADE_LEDGER_PROTOCOL_VERSION = protocolVersion;
+                if (!testutil::isTestApplicationProtocolVersionSupported(cfg))
+                {
+                    SUCCEED("Skipping historical Soroban protocol test: requested "
+                        "protocol is not linked in this build");
+                    return;
+                }
         VirtualClock clock;
         Application::pointer app = createTestApplication(clock, cfg);
 
@@ -1671,7 +1685,7 @@ TEST_CASE("tx set hits overlay byte limit during construction",
 {
     Config cfg(getTestConfig());
     cfg.TESTING_UPGRADE_LEDGER_PROTOCOL_VERSION =
-        static_cast<uint32_t>(SOROBAN_PROTOCOL_VERSION);
+        Config::CURRENT_LEDGER_PROTOCOL_VERSION;
     auto max = std::numeric_limits<uint32_t>::max();
     cfg.TESTING_UPGRADE_MAX_TX_SET_SIZE = max;
     // Pre-create enough genesis accounts for the test
diff --git a/src/herder/test/TransactionQueueTests.cpp b/src/herder/test/TransactionQueueTests.cpp
@@ -1430,6 +1430,15 @@ TEST_CASE("TransactionQueue Key Filtering", "[soroban][transactionqueue]")
     }
     SECTION("protocol version 24")
     {
+        auto cfg = getTestConfig();
+        cfg.TESTING_UPGRADE_LEDGER_PROTOCOL_VERSION = 24;
+        if (!testutil::isTestApplicationProtocolVersionSupported(cfg))
+        {
+            SUCCEED("Skipping historical Soroban protocol test: requested "
+                    "protocol is not linked in this build");
+            return;
+        }
+
         SECTION("should filter")
         {
             for (auto const& keyToFilter : keysToFilterP24)
diff --git a/src/herder/test/TxSetTests.cpp b/src/herder/test/TxSetTests.cpp
@@ -482,6 +482,12 @@ testGeneralizedTxSetXDRConversion(ProtocolVersion protocolVersion)
     cfg.TESTING_UPGRADE_LEDGER_PROTOCOL_VERSION =
         static_cast<uint32_t>(protocolVersion);
     cfg.GENESIS_TEST_ACCOUNT_COUNT = 10000;
+    if (!testutil::isTestApplicationProtocolVersionSupported(cfg))
+    {
+        SUCCEED("Skipping historical Soroban protocol test: requested "
+                "protocol is not linked in this build");
+        return;
+    }
     bool isParallelSoroban = protocolVersionStartsFrom(
         cfg.LEDGER_PROTOCOL_VERSION, PARALLEL_SOROBAN_PHASE_PROTOCOL_VERSION);
 
@@ -1064,6 +1070,16 @@ TEST_CASE("generalized tx set XDR conversion", "[txset]")
 TEST_CASE("applicable txset validation - Soroban phase version is correct",
           "[txset][soroban]")
 {
+    auto historicalCfg = getTestConfig();
+    historicalCfg.TESTING_UPGRADE_LEDGER_PROTOCOL_VERSION =
+        static_cast<uint32_t>(PARALLEL_SOROBAN_PHASE_PROTOCOL_VERSION) - 1;
+    if (!testutil::isTestApplicationProtocolVersionSupported(historicalCfg))
+    {
+        SUCCEED("Skipping historical Soroban protocol test: requested "
+                "protocol is not linked in this build");
+        return;
+    }
+
     auto runTest = [](uint32_t protocolVersion,
                       bool useParallelSorobanPhase) -> TxSetValidationResult {
         VirtualClock clock;
@@ -2497,10 +2513,15 @@ runParallelTxSetBuildingTest(bool variableStageCount)
 
     VirtualClock clock;
     auto cfg = getTestConfig();
-    cfg.LEDGER_PROTOCOL_VERSION =
-        static_cast<uint32_t>(PARALLEL_SOROBAN_PHASE_PROTOCOL_VERSION);
-    cfg.TESTING_UPGRADE_LEDGER_PROTOCOL_VERSION =
+    uint32_t testLedgerProtocolVersion =
         static_cast<uint32_t>(PARALLEL_SOROBAN_PHASE_PROTOCOL_VERSION);
+#ifdef ENABLE_FASTDEV_UNSAFE_FOR_PRODUCTION
+    // Fastdev only links recent Soroban hosts, so avoid forcing this test
+    // through the first historical parallel-Soroban protocol in next builds.
+    testLedgerProtocolVersion = Config::CURRENT_LEDGER_PROTOCOL_VERSION - 1;
+#endif
+    cfg.LEDGER_PROTOCOL_VERSION = testLedgerProtocolVersion;
+    cfg.TESTING_UPGRADE_LEDGER_PROTOCOL_VERSION = testLedgerProtocolVersion;
     cfg.SOROBAN_PHASE_MIN_STAGE_COUNT = variableStageCount ? 1 : STAGE_COUNT;
     cfg.SOROBAN_PHASE_MAX_STAGE_COUNT = STAGE_COUNT;
     // Temporary set the limits override very high in order for the upgrades
diff --git a/src/herder/test/UpgradesTests.cpp b/src/herder/test/UpgradesTests.cpp
@@ -1047,6 +1047,12 @@ TEST_CASE("upgrades affect in-memory Soroban state state size",
     auto cfg = getTestConfig();
     cfg.TESTING_UPGRADE_LEDGER_PROTOCOL_VERSION = 22;
     cfg.USE_CONFIG_FOR_GENESIS = true;
+    if (!testutil::isTestApplicationProtocolVersionSupported(cfg))
+    {
+        SUCCEED("Skipping historical Soroban protocol test: requested "
+                "protocol is not linked in this build");
+        return;
+    }
 
     uint32_t const windowSize = 15;
     uint32_t const samplePeriod = 4;
@@ -3892,6 +3898,12 @@ TEST_CASE("protocol 23 upgrade sets default SCP timing values", "[upgrades]")
     VirtualClock clock;
     auto cfg = getTestConfig(0, Config::TESTDB_IN_MEMORY);
     cfg.TESTING_UPGRADE_LEDGER_PROTOCOL_VERSION = 22;
+    if (!testutil::isTestApplicationProtocolVersionSupported(cfg))
+    {
+        SUCCEED("Skipping historical Soroban protocol test: requested "
+                "protocol is not linked in this build");
+        return;
+    }
 
     auto app = createTestApplication(clock, cfg);
     auto& lm = app->getLedgerManager();
@@ -4043,6 +4055,12 @@ TEST_CASE("p24 upgrade fixes corrupted hot archive entries",
     Config cfg(getTestConfig());
     cfg.USE_CONFIG_FOR_GENESIS = true;
     cfg.TESTING_UPGRADE_LEDGER_PROTOCOL_VERSION = corruptedProtocolVersion;
+    if (!testutil::isTestApplicationProtocolVersionSupported(cfg))
+    {
+        SUCCEED("Skipping historical Soroban protocol test: requested "
+                "protocol is not linked in this build");
+        return;
+    }
     auto app = createTestApplication(clock, cfg);
     gIsProductionNetwork = true;
     overrideSorobanNetworkConfigForTest(*app);
diff --git a/src/test/TestUtils.cpp b/src/test/TestUtils.cpp
@@ -6,6 +6,7 @@
 #include "herder/TxSetFrame.h"
 #include "ledger/ImmutableLedgerView.h"
 #include "ledger/test/LedgerTestUtils.h"
+#include "rust/RustBridge.h"
 #include "simulation/LoadGenerator.h"
 #include "simulation/Simulation.h"
 #include "test/TxTests.h"
@@ -16,12 +17,120 @@
 #include "work/WorkScheduler.h"
 #include "xdrpp/marshal.h"
 
+#include <algorithm>
+#include <sstream>
+
 namespace stellar
 {
 
 namespace testutil
 {
 
+bool isTestApplicationProtocolVersionSupported(Config const& cfg);
+
+namespace
+{
+bool
+isProtocolBackedByLinkedSorobanHost(uint32_t protocolVersion,
+                                    std::vector<uint32_t> const& hostProtocols)
+{
+    if (protocolVersionIsBefore(protocolVersion, SOROBAN_PROTOCOL_VERSION))
+    {
+        return true;
+    }
+
+    auto selectedHost = std::find_if(
+        hostProtocols.begin(), hostProtocols.end(),
+        [&](uint32_t hostProtocol) { return protocolVersion <= hostProtocol; });
+    if (selectedHost == hostProtocols.end())
+    {
+        return false;
+    }
+
+    // Protocol 20 is serviced by the p21 host. All later Soroban protocols
+    // should have their own linked host in non-fastdev builds.
+    return protocolVersion == static_cast<uint32_t>(SOROBAN_PROTOCOL_VERSION)
+               ? *selectedHost == static_cast<uint32_t>(ProtocolVersion::V_21)
+               : *selectedHost == protocolVersion;
+}
+
+std::string
+joinProtocolVersions(std::vector<uint32_t> const& protocolVersions)
+{
+    std::ostringstream out;
+    for (size_t i = 0; i < protocolVersions.size(); ++i)
+    {
+        if (i != 0)
+        {
+            out << ", ";
+        }
+        out << protocolVersions[i];
+    }
+    return out.str();
+}
+}
+
+void
+validateTestApplicationProtocolVersion(Config const& cfg)
+{
+    if (isTestApplicationProtocolVersionSupported(cfg))
+    {
+        return;
+    }
+
+    auto const protocolVersion = cfg.TESTING_UPGRADE_LEDGER_PROTOCOL_VERSION;
+    std::vector<uint32_t> hostProtocols;
+    auto rustVersions = rust_bridge::get_soroban_version_info(
+        Config::CURRENT_LEDGER_PROTOCOL_VERSION);
+    for (auto const& host : rustVersions)
+    {
+        hostProtocols.emplace_back(host.env_max_proto);
+    }
+
+    std::ostringstream msg;
+    msg << "Test application requested genesis ledger protocol "
+        << protocolVersion
+        << ", but this binary does not have the matching Soroban host linked. "
+        << "Linked Soroban host protocols: ["
+        << joinProtocolVersions(hostProtocols)
+        << "]. This usually means the build is using fastdev/unified Rust "
+        << "mode, where historical Soroban protocols are collapsed to a newer "
+        << "host and can fail later with opaque Soroban invocation errors. "
+        << "Use a linked protocol for this test, or rebuild without fastdev "
+        << "when testing historical Soroban protocol behavior.";
+    throw std::runtime_error(msg.str());
+}
+
+bool
+isTestApplicationProtocolVersionSupported(Config const& cfg)
+{
+    if (!cfg.USE_CONFIG_FOR_GENESIS)
+    {
+        return true;
+    }
+
+    auto const protocolVersion = cfg.TESTING_UPGRADE_LEDGER_PROTOCOL_VERSION;
+    if (protocolVersionIsBefore(protocolVersion, SOROBAN_PROTOCOL_VERSION))
+    {
+        return true;
+    }
+
+    std::vector<uint32_t> hostProtocols;
+    auto rustVersions = rust_bridge::get_soroban_version_info(
+        Config::CURRENT_LEDGER_PROTOCOL_VERSION);
+    for (auto const& host : rustVersions)
+    {
+        hostProtocols.emplace_back(host.env_max_proto);
+    }
+
+    if (isProtocolBackedByLinkedSorobanHost(protocolVersion, hostProtocols))
+    {
+        return true;
+    }
+
+    return false;
+}
+
 void
 crankSome(VirtualClock& clock)
 {
diff --git a/src/test/TestUtils.h b/src/test/TestUtils.h
@@ -34,6 +34,9 @@ std::vector<Asset> getInvalidAssets(SecretKey const& issuer);
 
 int32_t computeMultiplier(LedgerEntry const& le);
 
+bool isTestApplicationProtocolVersionSupported(Config const& cfg);
+void validateTestApplicationProtocolVersion(Config const& cfg);
+
 template <class BucketT> class BucketListDepthModifier
 {
     BUCKET_TYPE_ASSERT(BucketT);
@@ -90,6 +93,7 @@ std::shared_ptr<T>
 createTestApplication(VirtualClock& clock, Config const& cfg, Args&&... args,
                       bool newDB = true, bool startApp = true)
 {
+    testutil::validateTestApplicationProtocolVersion(cfg);
     Config c2(cfg);
     c2.adjust();
     auto app = Application::create<T, Args...>(
diff --git a/src/transactions/test/FrozenLedgerKeysTests.cpp b/src/transactions/test/FrozenLedgerKeysTests.cpp
@@ -150,6 +150,12 @@ TEST_CASE("frozen ledger keys config setting does not exist prior to p26",
     cfg.LEDGER_PROTOCOL_VERSION = static_cast<uint32_t>(ProtocolVersion::V_25);
     cfg.TESTING_UPGRADE_LEDGER_PROTOCOL_VERSION =
         static_cast<uint32_t>(ProtocolVersion::V_25);
+    if (!testutil::isTestApplicationProtocolVersionSupported(cfg))
+    {
+        SUCCEED("Skipping historical Soroban protocol test: requested "
+                "protocol is not linked in this build");
+        return;
+    }
     auto app = createTestApplication(clock, cfg);
     auto root = app->getRoot();
     CheckValidLedgerViewWrapper ledgerView(*app);
@@ -166,6 +172,12 @@ TEST_CASE("freeze bypass txs config setting does not exist prior to p26",
     cfg.LEDGER_PROTOCOL_VERSION = static_cast<uint32_t>(ProtocolVersion::V_25);
     cfg.TESTING_UPGRADE_LEDGER_PROTOCOL_VERSION =
         static_cast<uint32_t>(ProtocolVersion::V_25);
+    if (!testutil::isTestApplicationProtocolVersionSupported(cfg))
+    {
+        SUCCEED("Skipping historical Soroban protocol test: requested "
+                "protocol is not linked in this build");
+        return;
+    }
     auto app = createTestApplication(clock, cfg);
     auto root = app->getRoot();
     CheckValidLedgerViewWrapper ledgerView(*app);
diff --git a/src/transactions/test/InvokeHostFunctionTests.cpp b/src/transactions/test/InvokeHostFunctionTests.cpp

Original file line number	Diff line number	Diff line change
`@@ -1430,6 +1430,15 @@ TEST_CASE("TransactionQueue Key Filtering", "[soroban][transactionqueue]")`
`1430`	`1430`	`}`
`1431`	`1431`	`SECTION("protocol version 24")`
`1432`	`1432`	`{`
	`1433`	`+ auto cfg = getTestConfig();`
	`1434`	`+ cfg.TESTING_UPGRADE_LEDGER_PROTOCOL_VERSION = 24;`
	`1435`	`+ if (!testutil::isTestApplicationProtocolVersionSupported(cfg))`
	`1436`	`+ {`
	`1437`	`+ SUCCEED("Skipping historical Soroban protocol test: requested "`
	`1438`	`+ "protocol is not linked in this build");`
	`1439`	`+ return;`
	`1440`	`+ }`
	`1441`	`+`
`1433`	`1442`	`SECTION("should filter")`
`1434`	`1443`	`{`
`1435`	`1444`	`for (auto const& keyToFilter : keysToFilterP24)`