Update names/comments

Author: drebelsky

src/ledger/LedgerManager.h

@@ -302,11 +302,11 @@ class LedgerManager
 
     // Records the submission time of a self-submitted transaction for the
     // tx-latency metrics. No-op unless
-    // Config::LOADGEN_MEASURE_TX_LATENCY_FOR_TESTING is set.
+    // Config::LOADGEN_MEASURE_TX_E2E_LATENCY_FOR_TESTING is set.
     virtual void recordTxSubmission(Hash const& contentsHash) = 0;
 
     // Begins/ends a load-generation latency measurement window. No-op unless
-    // Config::LOADGEN_MEASURE_TX_LATENCY_FOR_TESTING is set.
+    // Config::LOADGEN_MEASURE_TX_E2E_LATENCY_FOR_TESTING is set.
     virtual void beginTxLatencyMeasurement(uint32_t expectedTxCount) = 0;
     virtual void finalizeTxLatencyMeasurement() = 0;
 #endif

src/ledger/LedgerManagerImpl.cpp

@@ -1362,14 +1362,13 @@ LedgerManagerImpl::recordTxSubmission(Hash const& contentsHash)
 }
 
 void
-LedgerManagerImpl::recordTxMetaEmissionLatency(
-    ApplicableTxSetFrame const& txSet)
+LedgerManagerImpl::recordTxE2eLatency(ApplicableTxSetFrame const& txSet)
 {
     if (!mApp.getConfig().LOADGEN_MEASURE_TX_E2E_LATENCY_FOR_TESTING)
     {
         return;
     }
-    VirtualClock::time_point const emitTime = mApp.getClock().now();
+    VirtualClock::time_point const applyEndTime = mApp.getClock().now();
     MutexLocker guard(mTxLatencyMetrics.mMutex);
     for (auto const& phase : txSet.getPhases())
     {
@@ -1379,7 +1378,7 @@ LedgerManagerImpl::recordTxMetaEmissionLatency(
                     tx->getContentsHash());
                 submitted != mTxLatencyMetrics.mTxSubmitTimes.end())
             {
-                auto const latency = emitTime - submitted->second;
+                auto const latency = applyEndTime - submitted->second;
                 mTxLatencyMetrics.mTxsExternalized.inc();
                 int64_t const ms =
                     std::chrono::duration_cast<std::chrono::milliseconds>(
@@ -2032,7 +2031,7 @@ LedgerManagerImpl::applyLedger(LedgerCloseData const& ledgerData,
 #ifdef BUILD_TESTS
     maybeSimulateSleep(mApp.getConfig(), txSet->sizeOpTotalForLogging(),
                        applyLedgerTime, mApplySleepRng);
-    recordTxMetaEmissionLatency(*applicableTxSet);
+    recordTxE2eLatency(*applicableTxSet);
 #endif
 
     // Steps 6, 7, 8 are done in `advanceLedgerStateAndPublish`

src/ledger/LedgerManagerImpl.h

@@ -451,15 +451,15 @@ class LedgerManagerImpl : public LedgerManager
         ANNOTATED_MUTEX(mMutex);
         UnorderedMap<Hash, VirtualClock::time_point>
             mTxSubmitTimes GUARDED_BY(mMutex);
-        // Each recorded submission -> meta-emission latency in ms
+        // Each recorded submission -> post-apply latency in ms
         std::vector<uint32_t> mSamples GUARDED_BY(mMutex);
 
         TxLatencyMetrics(MetricsRegistry& registry);
     } mTxLatencyMetrics;
 
-    // End point of the tx-latency metric: records the submission to meta
-    // emission latency for each externalized transaction.
-    void recordTxMetaEmissionLatency(ApplicableTxSetFrame const& txSet);
+    // End point of the tx-latency metric: records the submission to post-apply
+    // latency for each externalized transaction.
+    void recordTxE2eLatency(ApplicableTxSetFrame const& txSet);
 #endif
 
     void setState(State s);