Commit cd96730
committed
Let the highest linked host cover its base protocol, re-record next baseline
With core at protocol 28 and no p29 submodule, a vnext build has the p28
host reporting 29, so protocol 28 had no exact linked host and
isProtocolBackedByLinkedSorobanHost rejected it -- failing 70 of 131 [tx]
cases. rs-soroban-env explicitly supports this: Host::maybe_check_protocol_version
bypasses its protocol check under "next" because "a 'next' host can be used
as the current host for both its base protocol and the next one", and
ParsedModule's meta-section check does the same. Accept the highest linked
host for protocolVersion + 1 on that basis.
Restricting it to the highest host keeps fastdev's collapse of historical
protocols onto a newer host detectable, which is what the exact-match rule
is there to catch.
Uncomment moduleCacheProtocolCount -= 1 in "Module cache across protocol
versions", as that test's own comment instructs when the next protocol
points at another copy of the current host: soroban_module_cache.rs routes
29 to p28_cache, so 29 adds no cache of its own.
Re-record test-tx-meta-baseline-next, which recorded protocol 28 and now
records 29. All 131 [tx] cases pass.1 parent c99e7e3 commit cd96730
31 files changed
Lines changed: 22940 additions & 1581 deletions
File tree
- src
- test
- transactions/test
- test-tx-meta-baseline-next
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
47 | 47 | | |
48 | 48 | | |
49 | 49 | | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
50 | 64 | | |
51 | 65 | | |
52 | 66 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7788 | 7788 | | |
7789 | 7789 | | |
7790 | 7790 | | |
7791 | | - | |
| 7791 | + | |
| 7792 | + | |
| 7793 | + | |
7792 | 7794 | | |
7793 | 7795 | | |
7794 | 7796 | | |
| |||
0 commit comments