Address code review comments

Author: karthikiyer56

docs/data/indexers/build-your-own/processors/token-transfer-processor/README.mdx

@@ -5,11 +5,11 @@ sidebar_position: 0
 
 ## Overview
 
-The Token Transfer Processor (TTP) is a [Go package](https://github.com/stellar/go/tree/ttp-v1.0.0/ingest/processors/token_transfer) which uses the [ingest-sdk](../../ingest-sdk/README.mdx) to parse Stellar network transaction data and derive token transfer events. Before TTP, developers had to manually parse complex ledger data, operation results, and ledger entry changes to understand when and how assets moved between accounts, contracts, and other entities on the network.
+The Token Transfer Processor (TTP) is a [Go package](https://github.com/stellar/go/tree/ttp-v1.0.0/ingest/processors/token_transfer) which uses the [ingest-sdk](../../ingest-sdk/README.mdx) to parse Stellar network transaction data and derive token transfer events. Before TTP, developers had to manually parse complex ledger data, operation results, and ledger entry changes to understand when and how value moved between accounts, contracts, and other entities on the network.
 
 Prior to [CAP-67 Unified Events][cap67], tracking token transfers required significant custom logic to handle different operation types, interpret ledger changes, and reconstruct the flow of assets. CAP-67 introduced a standardized event format that simplifies this process by providing a unified way to represent all token transfer activities.
 
-TTP serves provides a facade to CAP-67, automatically generating these standardized events from Stellar ledger data. It can operate in two modes:
+TTP serves as a facade to CAP-67, automatically generating these standardized events from Stellar ledger data. It can operate in two modes:
 
 - **Standalone mode**: TTP analyzes operations, operation results, and ledger entry changes to derive transfer events
 - **Unified events mode**: TTP reads directly from CAP-67 compliant unified events when available in the ledger data
@@ -18,7 +18,7 @@ For more details on operational modes, see the [Modes of Operation](#modes-of-op
 
 ## Key Features
 
-- Processes all classic and [SEP-41][sep41] token movements from classic operations and smart contract invocations:
+- Captures token movements resulting from:
 
   - Simple payments
   - Path payments
@@ -28,7 +28,8 @@ For more details on operational modes, see the [Modes of Operation](#modes-of-op
   - Claimable balance operations
   - Liquidity pool operations
   - Clawback operations
-  - Events from smart contract transactions - Stellar Asset Contract events + SEP-41 compliant token events
+  - Stellar Asset Contract events
+  - [SEP-41][sep41] compliant token events
 
 - Generates CAP-67 standardized token events:
 
@@ -106,7 +107,7 @@ For events from classic transactions and SAC events from smart contract transact
 
 :::
 
-## Go Usage
+## Go API Overview
 
 TTP provides three distinct functions which derive events from different levels of granularity from the underlying Stellar network data.
 
@@ -148,15 +149,15 @@ This function processes a single operation within a transaction and returns a li
 
 ## Modes of Operation
 
-TTP can operate in two distinct modes depending on how the ledger data was generated and what information is available:
+TTP can operate in two distinct modes depending on how the ledger data was generated and what information is available.
 
 ### Default Mode (Recommended)
 
 In default mode, TTP analyzes three sources of information to derive token transfer events:
 
-- **Operations**: The actual operations submitted in transactions
+- **Operations**: The operations submitted in transactions
 - **Operation Results**: The success/failure results of each operation
-- **Ledger Entry Changes**: The actual changes made to the ledger state
+- **Ledger Entry Changes**: The changes made to the ledger state
 
 This mode works with all Stellar ledgers regardless of how they were generated or which stellar-core version produced them. It is the safest and most compatible option.
 
@@ -174,9 +175,11 @@ In unified events stream mode, TTP reads token transfer events directly from the
 processor := token_transfer.NewEventsProcessorForUnifiedEvents(networkPassphrase)
 ```
 
+Only use unified events stream mode if you are certain that your ledgers contain unified events. These ledgers must be generated by stellar-core with both `EMIT_CLASSIC_EVENTS=true` and `BACKFILL_STELLAR_ASSET_EVENTS=true` configuration flags enabled. TTP cannot dynamically determine whether a ledger contains unified events or not.
+
 :::caution
 
-Only use unified events stream mode if you are certain that your ledgers contain unified events. These ledgers must be generated by stellar-core with both `EMIT_CLASSIC_EVENTS=true` and `BACKFILL_STELLAR_ASSET_EVENTS=true` configuration flags enabled. TTP cannot dynamically determine whether a ledger contains unified events or not. If you configure TTP for unified events mode and then provide it ledgers without unified events, TTP will silently produce no events.
+If you configure TTP for unified events mode and then provide it ledgers without unified events, TTP will silently produce no events.
 
 :::
 

docs/data/indexers/build-your-own/processors/token-transfer-processor/examples/README.mdx

@@ -7,12 +7,12 @@ This section contains examples of how Token Transfer Processor can be used in yo
 
 ## Prerequisites
 
-Some of the examples listed here might invoke the `stellar-core` binary. Refer [this section](../../../ingest-sdk/developer_guide/ledgerbackends/captivecore.mdx) for more details on how to compile `stellar-core` for your platform.
-
 ```
 //filename: go.mod
 
 require (
+    // This currently points to a RC release of Protocol-23.
+    // Please update it to use the latest stable version once P23 is released to pubnet.
     github.com/stellar/go horizonclient-v23.0.0-rc
 )
 
@@ -32,12 +32,13 @@ package main
 import (
 	"context"
 	"fmt"
-	"github.com/sirupsen/logrus"
+
 	"github.com/stellar/go/ingest/ledgerbackend"
-	"github.com/stellar/go/network"
+	"github.com/stellar/go/processors/token_transfer"
 	"github.com/stellar/go/support/log"
 	"github.com/stellar/go/xdr"
-	"os"
+
+	"google.golang.org/protobuf/encoding/protojson"
 )
 
 func panicIf(err error) {
@@ -46,51 +47,29 @@ func panicIf(err error) {
 	}
 }
 
-// This example runs a captive core instance to get a ledger.
-// You can just as easily replace it with a BufferedStorageBackend to read from GCS.
-func fetchLedger(ledgerSeq uint32, unifiedEventsEnabled bool) xdr.LedgerCloseMeta {
-	archiveURLs := network.PublicNetworkhistoryArchiveURLs
-	networkPassphrase := network.PublicNetworkPassphrase
-	captiveCoreToml, err := ledgerbackend.NewCaptiveCoreToml(ledgerbackend.CaptiveCoreTomlParams{
-		EmitUnifiedEvents:  unifiedEventsEnabled,
-		NetworkPassphrase:  networkPassphrase,
-		HistoryArchiveURLs: archiveURLs,
-	})
-	panicIf(err)
-
-	config := ledgerbackend.CaptiveCoreConfig{
-		// Change these based on your environment:
-		BinaryPath:         "/Users/karthik/WS/stellar-core-2/src/stellar-core",
-		NetworkPassphrase:  networkPassphrase,
-		HistoryArchiveURLs: archiveURLs,
-		Toml:               captiveCoreToml,
-	}
+// fetchLedgerFromRPC retrieves a ledger using RPCLedgerBackend
+func fetchLedgerFromRPC(ledgerSeq uint32) xdr.LedgerCloseMeta {
+	ctx := context.Background()
 
-	// Log Captive Core straight to stdout by default
-	if config.Log == nil {
-		config.Log = log.New()
-		config.Log.SetOutput(os.Stdout)
-		config.Log.SetLevel(logrus.ErrorLevel)
-	}
+	// Using a publicly hosted RPC instance
+	endpoint := "https://mainnet.sorobanrpc.com"
 
-	// Prepare backend connection
-	ctx := context.Background()
-	backend, err := ledgerbackend.NewCaptive(config)
-	panicIf(err)
+	// Configure the RPC Ledger Backend
+	backend := ledgerbackend.NewRPCLedgerBackend(ledgerbackend.RPCLedgerBackendOptions{
+		RPCServerURL: endpoint,
+	})
 	defer backend.Close()
 
-	fmt.Printf("Fetching ledgerSequence: %v\n", ledgerSeq)
-	// Prepare and retrieve the ledger
-	err = backend.PrepareRange(ctx, ledgerbackend.BoundedRange(ledgerSeq, ledgerSeq))
-	panicIf(err)
+	// Prepare an unbounded range starting from the latest ledger
+	if err := backend.PrepareRange(ctx, ledgerbackend.BoundedRange(ledgerSeq, ledgerSeq)); err != nil {
+		log.Fatalf("Failed to prepare range: %v", err)
+	}
 
 	ledger, err := backend.GetLedger(ctx, ledgerSeq)
 	panicIf(err)
-
 	return ledger
 }
 
-// Helper function to print the protobuf event.
 func printProtoEvent(event *token_transfer.TokenTransferEvent) {
 	jsonBytes, _ := protojson.MarshalOptions{
 		Multiline:         true,
@@ -100,7 +79,6 @@ func printProtoEvent(event *token_transfer.TokenTransferEvent) {
 	fmt.Printf("### Event Type : %v\n", event.GetEventType())
 	fmt.Println(string(jsonBytes))
 }
-
 ```
 
 </CodeExample>

docs/data/indexers/build-your-own/processors/token-transfer-processor/examples/event_stats.mdx

@@ -12,33 +12,20 @@ package main
 
 import (
 	"fmt"
+	"strings"
+
 	"github.com/stellar/go/network"
 	"github.com/stellar/go/processors/token_transfer"
-	"log"
-	"strings"
 )
 
 func main() {
 	ledgerSeq := uint32(58155263)
-
-	// Toggle this flag to read from ledgerEntrychanges or from P23 unified events stream
-	unifiedEventsEnabled := false
-
-	ledger := fetchLedger(ledgerSeq, unifiedEventsEnabled)
-
-	var ttp *token_transfer.EventsProcessor
-
-	if unifiedEventsEnabled {
-		ttp = token_transfer.NewEventsProcessorForUnifiedEvents(network.PublicNetworkPassphrase)
-	} else {
-		ttp = token_transfer.NewEventsProcessor(network.PublicNetworkPassphrase)
-	}
+	ledger := fetchLedgerFromRPC(ledgerSeq)
+	ttp := token_transfer.NewEventsProcessor(network.PublicNetworkPassphrase)
 
 	// Process events from a single ledger
 	events, err := ttp.EventsFromLedger(ledger)
-	if err != nil {
-		log.Fatal("Error processing ledger:", err)
-	}
+	panicIf(err)
 
 	// Statistics counters
 	var transferCount, mintCount, burnCount, clawbackCount, feeCount, refundCount int

docs/data/indexers/build-your-own/processors/token-transfer-processor/examples/filter_events.mdx

@@ -27,7 +27,6 @@ package main
 
 import (
 	"fmt"
-	"github.com/stellar/go/xdr"
 	"io"
 	"log"
 	"strings"
@@ -36,6 +35,7 @@ import (
 	"github.com/stellar/go/ingest"
 	"github.com/stellar/go/network"
 	"github.com/stellar/go/processors/token_transfer"
+	"github.com/stellar/go/xdr"
 )
 
 // FilterOptions defines the filtering criteria
@@ -47,14 +47,9 @@ type FilterOptions struct {
 }
 
 // filterEvents processes a ledger and returns events matching the filter criteria
-func filterEvents(ledger xdr.LedgerCloseMeta, unifiedEventsEnabled bool, filter FilterOptions) {
+func filterEvents(ledger xdr.LedgerCloseMeta, filter FilterOptions) {
 
-	var ttp *token_transfer.EventsProcessor
-	if unifiedEventsEnabled {
-		ttp = token_transfer.NewEventsProcessorForUnifiedEvents(network.PublicNetworkPassphrase)
-	} else {
-		ttp = token_transfer.NewEventsProcessor(network.PublicNetworkPassphrase)
-	}
+	ttp := token_transfer.NewEventsProcessor(network.PublicNetworkPassphrase)
 
 	// Create transaction reader
 	txReader, err := ingest.NewLedgerTransactionReaderFromLedgerCloseMeta(
@@ -179,26 +174,25 @@ func matchesAsset(event *token_transfer.TokenTransferEvent, asset xdr.Asset) boo
 
 func main() {
 	ledgerSeq := uint32(58155263)
-	unifiedEventsEnabled := true
 
-	ledger := fetchLedger(ledgerSeq, unifiedEventsEnabled)
+	ledger := fetchLedgerFromRPC(ledgerSeq)
 
 	// Example 1: Filter by event type only
 	fmt.Println("=== Example 1: Only Transfer Events ===")
-	filterEvents(ledger, unifiedEventsEnabled, FilterOptions{
+	filterEvents(ledger, FilterOptions{
 		EventType: "transfer",
 	})
 
 	// Example 2: Filter by custom token (asset code + issuer)
 	fmt.Println("\n=== Example 2: Only USDC Events ===")
-	filterEvents(ledger, unifiedEventsEnabled, FilterOptions{
+	filterEvents(ledger, FilterOptions{
 		AssetCode: "USDC",
 		Issuer:    "GA5ZSEJYB37JRC5AVCIA5MOP4RHTM335X2KGX3IHOJAPP5RE34K4KZVN",
 	})
 
 	// Example 3: Filter by event type + contract ID
 	fmt.Println("\n=== Example 3: Transfer Events from Specific Contract (USDC in this case) ===")
-	filterEvents(ledger, unifiedEventsEnabled, FilterOptions{
+	filterEvents(ledger, FilterOptions{
 		EventType: "transfer",
 		// This is the SAC id for the USDC asset on pubnet
 		// https://stellar.expert/explorer/public/contract/CCW67TSZV3SSS2HXMBQ5JFGCKJNXKZM7UQUWUZPUTHXSTZLEO7SJMI75
@@ -207,21 +201,21 @@ func main() {
 
 	// Example 4: Filter by event type + asset code + issuer
 	fmt.Println("\n=== Example 4: Only KALE mints ===")
-	filterEvents(ledger, unifiedEventsEnabled, FilterOptions{
+	filterEvents(ledger, FilterOptions{
 		EventType: "mint",
 		AssetCode: "KALE",
 		Issuer:    "GBDVX4VELCDSQ54KQJYTNHXAHFLBCA77ZY2USQBM4CSHTTV7DME7KALE",
 	})
 
 	// Example 5: Filter by XLM events only
 	fmt.Println("\n=== Example 5: Only XLM Events ===")
-	filterEvents(ledger, unifiedEventsEnabled, FilterOptions{
+	filterEvents(ledger, FilterOptions{
 		AssetCode: "native",
 	})
 
 	// Example 6: Filter by fee events only
 	fmt.Println("\n=== Example 6: Only Fee Events ===")
-	filterEvents(ledger, unifiedEventsEnabled, FilterOptions{
+	filterEvents(ledger, FilterOptions{
 		EventType: "fee",
 	})
 }