dryrun multiple ConfigurationPolicy

[tomilho]

Hi all,

I have been using dryrun cmd to test policies. At the moment, I am creating Policy where there are extra dependencies, similar to what is below (I redacted many values and keys, but the idea is that we have some extra dependencies):

apiVersion: policy.open-cluster-management.io/v1
kind: Policy
name: acm-policy
spec:
  policy-templates:
  - objectDefinition:
      apiVersion: policy.open-cluster-management.io/v1
      kind: ConfigurationPolicy
      spec:
        object-templates:
        - complianceType: mustonlyhave
          metadataComplianceType: musthave
          objectDefinition:
            apiVersion: v1
            kind: Namespace
        pruneObjectBehavior: None
        remediationAction: enforce
        severity: low
  - extraDependencies:
    - apiVersion: policy.open-cluster-management.io/v1
      compliance: Compliant
      kind: ConfigurationPolicy
    objectDefinition:
      apiVersion: policy.open-cluster-management.io/v1
      kind: ConfigurationPolicy
      spec:
        object-templates-raw: |
  remediationAction: enforce

Unfortunately, the dryrun command only processes the first ConfigurationPolicy and ignores the rest which makes it rather cumbersome to use because I end up having to delete the top ConfigurationPolicy to dryrun the next one. :(

Looking at the source code, it looks to me that this is intended but I am not sure if you would be open if I create a PR to adapt the code to support extraDependencies?

[dhaiducek]

Thanks for opening both an issue and a PR! For the PR, features are first delivered upstream to:

• https://github.com/open-cluster-management-io/config-policy-controller

We've also commented in the PR in this regard, but let us know if there are questions about it:

• support multiple configpolicy in Policy #1646 (comment)