Skip to content

Commit ce2cbaa

Browse files
ACM-24107 add search fields (#5006)
* Inflate additional VM and VMI fields Signed-off-by: Kevin Cormier <kcormier@redhat.com> * Update test case Signed-off-by: Kevin Cormier <kcormier@redhat.com> * Fix CPU metric data types Signed-off-by: Kevin Cormier <kcormier@redhat.com> * Update test to catch CPU type problem Signed-off-by: Kevin Cormier <kcormier@redhat.com> --------- Signed-off-by: Kevin Cormier <kcormier@redhat.com>
1 parent 63eecfa commit ce2cbaa

2 files changed

Lines changed: 22 additions & 3 deletions

File tree

frontend/packages/multicluster-sdk/src/api/useFleetSearchPoll.test.ts

Lines changed: 17 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -471,14 +471,15 @@ describe('useFleetSearchPoll', () => {
471471
...mockSearchResultItem,
472472
kind: 'VirtualMachine',
473473
apigroup: 'kubevirt.io',
474-
cpu: 2,
474+
cpu: '2',
475475
memory: '4Gi',
476476
ready: 'True',
477477
status: 'Running',
478478
flavor: 'test',
479479
osName: 'rhel',
480480
workload: 'app',
481481
runStrategy: 'Always',
482+
architecture: 'amd64',
482483
condition: 'Ready=True; AgentConnected=True',
483484
dataVolumeNames: 'test-volume1; test-volume2',
484485
pvcClaimNames: 'test-claim1; test-claim2',
@@ -505,6 +506,7 @@ describe('useFleetSearchPoll', () => {
505506
runStrategy: 'Always',
506507
template: {
507508
spec: {
509+
architecture: 'amd64',
508510
domain: {
509511
cpu: { cores: 2 },
510512
memory: { guest: '4Gi' },
@@ -615,6 +617,10 @@ describe('useFleetSearchPoll', () => {
615617
...mockSearchResultItem,
616618
kind: 'VirtualMachineInstance',
617619
apigroup: 'kubevirt.io',
620+
cpu: '4',
621+
cpuSockets: '2',
622+
cpuThreads: '2',
623+
memory: '8Gi',
618624
liveMigratable: 'True',
619625
ready: 'True',
620626
ipaddress: '10.0.0.1',
@@ -640,6 +646,16 @@ describe('useFleetSearchPoll', () => {
640646
const { result } = renderHook(() => useFleetSearchPoll<any[]>(watchOptionsVMI))
641647

642648
const [data] = result.current
649+
expect(data?.[0].spec).toEqual({
650+
domain: {
651+
cpu: {
652+
cores: 4,
653+
sockets: 2,
654+
threads: 2,
655+
},
656+
memory: { guest: '8Gi' },
657+
},
658+
})
643659
expect(data?.[0].status).toEqual({
644660
conditions: [
645661
{ type: 'LiveMigratable', status: 'True' },

frontend/packages/multicluster-sdk/src/api/useFleetSearchPoll.ts

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -290,7 +290,8 @@ export function useFleetSearchPoll<T extends K8sResourceCommon | K8sResourceComm
290290

291291
case 'VirtualMachine.kubevirt.io': {
292292
setIfDefined(resource, 'spec.runStrategy', item.runStrategy)
293-
setIfDefined(resource, 'spec.template.spec.domain.cpu.cores', item.cpu)
293+
setIfDefined(resource, 'spec.template.spec.architecture', item.architecture)
294+
setIfDefined(resource, 'spec.template.spec.domain.cpu.cores', item.cpu, Number(item.cpu))
294295
setIfDefined(resource, 'spec.template.spec.domain.memory.guest', item.memory)
295296
setIfDefined(resource, 'spec.template.metadata.annotations["vm.kubevirt.io/flavor"]', item.flavor)
296297
setIfDefined(resource, 'spec.template.metadata.annotations["vm.kubevirt.io/os"]', item.osName)
@@ -334,7 +335,9 @@ export function useFleetSearchPoll<T extends K8sResourceCommon | K8sResourceComm
334335
}
335336

336337
case 'VirtualMachineInstance.kubevirt.io': {
337-
setIfDefined(resource, 'spec.domain.cpu.cores', item.cpu)
338+
setIfDefined(resource, 'spec.domain.cpu.cores', item.cpu, Number(item.cpu))
339+
setIfDefined(resource, 'spec.domain.cpu.sockets', item.cpuSockets, Number(item.cpuSockets))
340+
setIfDefined(resource, 'spec.domain.cpu.threads', item.cpuThreads, Number(item.cpuThreads))
338341
setIfDefined(resource, 'spec.domain.memory.guest', item.memory)
339342
if (!resource.status?.conditions) {
340343
const conditions: any = []

0 commit comments

Comments
 (0)