Default role for level, default role if none selected, and considerations for existing levels

[kimcoleman]

Describe the bug

This is more of a general feedback issue, some thoughts based on an in-person conversation and testing between Jason and myself.

Some high level points here:

If you create a new membership level and do not check the box for "Create a new custom role for this membership level", a role is still created and it is set for the membership level.

• What is the correct assumption for the behavior when no roles are selected?
• We need to decide whether a) the role for the level should not be created when the box is checked or b) change the wording of the setting and add some help text "If you do not select any other role for this level, we will default to adding a new level-specific role and assign that to users of this membership level.

If you have existing membership levels that did not have the role created for their level, there is no option to create the level-specific role at a later time.

• I recommend that we always have the option to add the level-specific role if it doesn't already exist.

It is unclear what role is given to the member if none of these boxes are checked?

• I believe we give the user the site default role as specified under Settings > General > "New User Default Role". If this is the case, should we show this in description text below the "Role Settings" heading. "If you do not select a custom role for users of this membership level, the user will be assigned the "New User Default Role" as defined under Settings > General in the WordPress admin.

There may be additional documentation updates we want to add after these decisions and the updates surrounding them are completed here.

[MaryOJob]

Moderators Only: #431324
When the box is not checked to create a role for a new level being created, the role is still automatically created.

[andrewlimaza]

This has been added to the latest dev branch, which also resolves some bugs with PMPro V3.0+