fix: address review feedback on e2e tests

- Add 5s timeout to HTTP client in sendWebhook to prevent hung tests
- TrimSpace on GITHUB_META_URL env var to handle trailing newlines
- Add e2e test verifying meta URL whitespace trimming works
- Remove explicit -timeout 60s from CI job (default 10m is sufficient)

Author: strayer

.github/workflows/ci.yaml

@@ -58,7 +58,7 @@ jobs:
     steps:
       - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
       - uses: jdx/mise-action@1648a7812b9aeae629881980618f079932869151 # v4.0.1
-      - run: go test ./e2e/ -tags e2e -v -timeout 60s
+      - run: go test ./e2e/ -tags e2e -v
 
   docker:
     name: Docker build

cmd/proxy/main.go

@@ -9,6 +9,7 @@ import (
 	"net/http"
 	"os"
 	"os/signal"
+	"strings"
 	"syscall"
 	"time"
 
@@ -27,7 +28,7 @@ func main() {
 		os.Exit(1)
 	}
 
-	metaURL := os.Getenv("GITHUB_META_URL")
+	metaURL := strings.TrimSpace(os.Getenv("GITHUB_META_URL"))
 	if metaURL == "" {
 		metaURL = defaultGitHubMetaURL
 	}

e2e/e2e_test.go

@@ -204,7 +204,8 @@ func sendWebhook(t *testing.T, addr, event, body, secret string) *http.Response
 	req.Header.Set("X-GitHub-Event", event)
 	req.Header.Set("X-Hub-Signature-256", sig)
 
-	resp, err := http.DefaultClient.Do(req)
+	client := &http.Client{Timeout: 5 * time.Second}
+	resp, err := client.Do(req)
 	if err != nil {
 		t.Fatalf("request failed: %v", err)
 	}
@@ -562,6 +563,30 @@ func TestE2E_ResponseBodyNotLeaked(t *testing.T) {
 	}
 }
 
+func TestE2E_MetaURLWhitespaceTrimmed(t *testing.T) {
+	meta := githubMetaServer([]string{"127.0.0.0/8"})
+	defer meta.Close()
+
+	capture := &docoCDCapture{}
+	docoCD := httptest.NewServer(capture.handler())
+	defer docoCD.Close()
+
+	env := baseEnv(meta.URL, docoCD.URL)
+	env["GITHUB_META_URL"] = "  " + meta.URL + "\n"
+
+	p := startProxy(t, env)
+
+	resp := sendWebhook(t, p.addr, "push", pushPayload, "test-gh-secret")
+	defer resp.Body.Close()
+
+	if resp.StatusCode != http.StatusOK {
+		t.Fatalf("expected 200, got %d — meta URL trimming may have failed", resp.StatusCode)
+	}
+	if !capture.wasCalled() {
+		t.Error("request should have been forwarded after meta URL trimming")
+	}
+}
+
 func TestE2E_MultipleAllowedRepos(t *testing.T) {
 	meta := githubMetaServer([]string{"127.0.0.0/8"})
 	defer meta.Close()