Removed game settings overrides - #3343
Conversation
|
I've never used this feature. Do we have alternative for this? If it is like that, it is an useful feature to have for multi-platform builds. |
|
@Ethereal77 What you are describing wasn't possible previously, as the graphics compositor was not in a configuration, so it couldn't be overridden. The things you could override were mostly not related to hardware or platform (e.g. physics) except for graphics level, which from what xen mentioned in the linked PR, it probably wouldn't have worked. Also specific filters didn't work at all. An alternative right now is to override the game class and add your own logic there (which is probably what you would have to do for most graphics-related settings). In the future, there could be a more proper way, like a replacement asset, but for now I'm just trying to remove this mostly broken feature |
xen2
left a comment
There was a problem hiding this comment.
- Found plenty of
Overrides:/PlatformFilters:in the repo (i.e. new game and other templates). Scan for any *.sdgamesettings in the repo and clean them up. - RecastMeshSystem.cs:55 doesn't compile anymore
- BepuConfiguration.cs:25-27 logic is now wrong I think (old Get() returned
new T()without saving it so it used to work). New code needs to run the presence check before calling GetConfiguration/GetOrCreateConfiguration (also removes the duplicate OfType scan).
|
PR Details
As discussed in #3272, removes the partially not working overrides from the game settings asset.
Breaking changes:
Game.Settings.Configurations.Get<>()is nowGame.Settings.GetConfiguration<>()Types of changes
Checklist