Commit 13654d2
harness(rg3): fold committee nits — K7 vacuous-pass report + K6 null-row cert gap
Review committee (glm + codex + reviewer) on #166 converged on two harness
self-cert weaknesses. Both empirically fixed and re-verified:
- k7RollbackNonVacuousOk was `!hasClass('K7') || (...)` → evaluated to `true`
when K7 is absent, so the `!== undefined` guards always fired and RESULT.md
printed a vacuous "K7 rollback non-vacuous: true" for a class that never ran.
Now `undefined` when K7 is absent → the guards skip it entirely, so an unrun
class no longer self-reports a pass. Verified: a K6-only run emits 0 K7 lines
and omits the k7 field from the summary JSON.
- k6CutoverOrganicOk checked only the distinct non-null killBlocks set, so a
kill row whose block was unreadable/null could slip past
`length===1 && [0]===106` when another row recorded 106. Now also requires
killBlocksRecordedCount === killCount (every kill recorded a block).
Re-verified the cert still bites: reverting k6-cutover.json to the pre-PR
fixed-block form flips accepted:false / k6CutoverOrganicOk:false, while the
organic form stays accepted:true with recorded==kill count==2.
node --test harness/chaos/realtime/mock-portal.test.mjs: 9/9. biome check .: exit 0.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>1 parent f70ace6 commit 13654d2
1 file changed
Lines changed: 11 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
546 | 546 | | |
547 | 547 | | |
548 | 548 | | |
549 | | - | |
550 | | - | |
| 549 | + | |
| 550 | + | |
| 551 | + | |
| 552 | + | |
| 553 | + | |
551 | 554 | | |
552 | 555 | | |
553 | 556 | | |
| |||
558 | 561 | | |
559 | 562 | | |
560 | 563 | | |
| 564 | + | |
561 | 565 | | |
562 | 566 | | |
563 | 567 | | |
| |||
605 | 609 | | |
606 | 610 | | |
607 | 611 | | |
| 612 | + | |
608 | 613 | | |
609 | 614 | | |
610 | 615 | | |
611 | 616 | | |
| 617 | + | |
| 618 | + | |
612 | 619 | | |
613 | | - | |
| 620 | + | |
| 621 | + | |
614 | 622 | | |
615 | 623 | | |
616 | 624 | | |
| |||
0 commit comments