fix(portal): persist discovered factory children to the sync store (#2)

The portal historical sync discovered factory children with its wide scan but
wrote them only to the in-memory childAddresses map — never to the sync store.
Core marks requiredFactoryIntervals cached after every interval and, on startup,
loads children ONLY from the store (no re-derivation from logs). So a single
uninterrupted run worked, but any restart/crash-resume of a factory app loaded
an empty child set against already-cached factory intervals — discovery never
re-ran and every factory-child event was silently skipped.

Fix: queue newly discovered children and flush them via
syncStore.insertChildAddresses inside syncBlockRangeData — the same transaction
core commits with insertIntervals, so "factory interval cached ⇒ its children
are in the store" is atomic. The flush is scoped to children whose creation
block falls within the current interval, leaving the rest queued for their
owning interval. Grabbing the whole cross-interval queue would commit one
interval's children in another interval's transaction and, under core's
concurrent per-interval transactions, could lose a child if that transaction
rolled back after a lower interval had committed as cached (restart
re-discovery is floored at the lowest uncached factory interval and would never
rescan it). This mirrors stock sync-historical's per-interval child set. A
failed flush restores the queue and fails the interval loud (core rolls back).

Tests: persistence in the same syncBlockRangeData call; interval-scoped flush
(fails against a whole-queue flush, verified); loud failure + re-flush;
post-flush insertLogs failure rejects loud; restart seeded only from the store;
live re-discovery de-dup.

Also: delete the orphaned packages/portal-sync/src/historical.ts prototype
(unimported duplicate of the live engine); fix the identical
noAssignInExpressions in portal-realtime.ts; add repo code-style rules
(CLAUDE.md + biome useSingleVarDeclarator).

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Author: mo4islona

CLAUDE.md

@@ -0,0 +1,34 @@
+# portal-ponder — contributor & agent rules
+
+Fork of Ponder's historical sync that backfills from SQD Portal. The Portal layer lives in
+`portal/`; `scripts/sync-upstream.sh` grafts it onto a pinned ponder checkout to build/test.
+
+## Code style
+
+These are enforced expectations for all TypeScript in this repo. Some are checked by Biome
+(`biome check .`); the rest are conventions Biome can't express — follow them anyway.
+
+1. **Braces on control-flow bodies.** An `if`/`for`/`while` whose body is a real statement
+   uses `{ }` — never a braceless multi-line body.
+   - **Exception:** a single-statement guard on one line stays braceless:
+     `if (!x) continue;` / `if (!x) break;` / `if (!x) return;`.
+
+2. **One variable per declaration.** Never `const a = 1, b = 2;` — one `const`/`let` each.
+   *(Biome flags this — `style/useSingleVarDeclarator`, currently `warn` while pre-existing
+   violations get cleaned up; bump to `error` once the repo is swept.)*
+
+3. **Let guards and returns breathe.** Blank line *after* a guard clause
+   (`if (...) continue;` / `break;`) when code follows, and a blank line *before* a `return`.
+
+4. **No assignment used as an expression.** No `(m ??= new Map()).set(...)` or
+   `while ((n = idx()) >= 0)` — expand into explicit statements.
+   *(Biome-enforced: `suspicious/noAssignInExpressions`.)*
+
+Match the surrounding code otherwise. `npm run lint` runs `biome check .`; `npm run lint:fix`
+applies the safe fixes.
+
+## Tests
+
+The Portal unit tests run inside the grafted ponder tree, not from this repo root:
+`scripts/sync-upstream.sh <ponder-version> --test` (config: `portal/vite.portal.config.ts`,
+files `portal/*.test.ts`). Keep every `portal/*.test.ts` green before pushing.

biome.json

@@ -16,7 +16,10 @@
   "linter": {
     "enabled": true,
     "rules": {
-      "preset": "recommended"
+      "recommended": true,
+      "style": {
+        "useSingleVarDeclarator": "warn"
+      }
     }
   },
   "javascript": {

packages/portal-sync/src/historical.ts

@@ -161,11 +161,14 @@ export async function* streamHotBlocks(
         const { done, value } = await reader.read();
         if (done) break;
         buf += dec.decode(value, { stream: true });
-        let nl: number;
-        while ((nl = buf.indexOf("\n")) >= 0) {
+        for (;;) {
+          const nl = buf.indexOf("\n");
+          if (nl < 0) break;
+
           const line = buf.slice(0, nl);
           buf = buf.slice(nl + 1);
           if (!line) continue;
+
           const batch = JSON.parse(line);
           if (batch?.header?.number != null) {
             cursor = batch.header.number + 1; // resume past this block on reconnect