Commit ec1e24b
docs(contributing): add a review checklist for cold-start progress ticker (#135)
CI (e2e gate + biome) does not assert that the per-chain Portal progress
ticker keeps advancing during a cold discovery scan on a dense source —
`scanned=` must climb even while `blocks_streamed=0` so a healthy run is
never mistaken for a hang. Add a Review checklist section reminding
reviewers to confirm any change to `progressFingerprint` preserves the
`discoveryScannedBlocks` field (locked by the scanned-only regression
test in `portal-metrics.test.ts`) and to eyeball the ticker on an example
PR's empty opening window.
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>1 parent 5aa12cf commit ec1e24b
1 file changed
Lines changed: 14 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
58 | 58 | | |
59 | 59 | | |
60 | 60 | | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
61 | 75 | | |
62 | 76 | | |
63 | 77 | | |
| |||
0 commit comments