Skip to content

Commit 5e81db8

Browse files
committed
test: generalize shared DOM test helper
Rename the shared DOM helper to make it reusable outside palette tests. Update palette.test.js to use the generic helper while preserving the existing test behavior.
1 parent 81cb3df commit 5e81db8

2 files changed

Lines changed: 10 additions & 10 deletions

File tree

js/__tests__/palette.test.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
const { Palettes, initPalettes } = require("../palette");
2222
const { mockDocById } = require("../../test/utils/domMocks");
2323
const { createMockActivity } = require("../../test/utils/activityFactory");
24-
const { createPaletteDOM } = require("../../test/utils/domFactory");
24+
const { createMockDOM } = require("../../test/utils/domFactory");
2525
const { setupImageMock } = require("../../test/utils/imageMock");
2626
const { setupSVGMock } = require("../../test/utils/svgMock");
2727
const { setupGlobalEnvironment } = require("../../test/setup/globalSetup");
@@ -101,7 +101,7 @@ describe("Palettes Class", () => {
101101
setupSVGMock();
102102

103103
// Real DOM instead of fake one
104-
const { paletteElement, paletteBody } = createPaletteDOM();
104+
const { container: paletteElement, body: paletteBody } = createMockDOM();
105105
mockDocById({
106106
palette: paletteElement,
107107
PaletteBody: paletteBody

test/utils/domFactory.js

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
1-
function createPaletteDOM() {
2-
const paletteElement = document.createElement("div");
3-
paletteElement.style.visibility = "visible";
4-
paletteElement.style.top = "100px";
1+
function createMockDOM() {
2+
const container = document.createElement("div");
3+
container.style.visibility = "visible";
4+
container.style.top = "100px";
55

6-
const paletteBody = document.createElement("div");
6+
const body = document.createElement("div");
77
const parent = document.createElement("div");
8-
parent.appendChild(paletteBody);
8+
parent.appendChild(body);
99

10-
return { paletteElement, paletteBody };
10+
return { container, body };
1111
}
1212

13-
module.exports = { createPaletteDOM };
13+
module.exports = { createMockDOM };

0 commit comments

Comments
 (0)