test(logo): address review feedback on coverage tests

- Strengthen behaviour assertions: replace toHaveBeenCalled() checks on
  mocked safePluginExecute/pluginFn with observable side-effect assertions
  (return value, block.value mutation, effects array) so tests survive
  refactors that preserve the same outcome via a different call path

- evalArgDict test now verifies parseArg returns the value the plugin
  wrote to blockList[blk].value rather than spying on the call

- evalOnStartList and evalFlowDict tests use real plugin functions that
  push to a side-effect array; no longer mock safePluginExecute

- safePluginExecute "function executes" test drops the redundant
  toHaveBeenCalledWith assertion — the return value already proves
  execution occurred

- Remove weak processSpeak smoke test (function body is empty; the test
  only proved it does not crash, not that it does anything)

- Consolidate console spy teardown with afterEach(jest.restoreAllMocks)
  in safePluginExecute, parseArg, and doStopTurtles describe blocks;
  remove the per-test mockRestore() calls that the afterEach now covers

Signed-off-by: Vanshika <pahalvanshikaa@gmail.com>

Author: vanshika2720

js/__tests__/logo.test.js

@@ -1705,10 +1705,10 @@ describe("Logo safePluginExecute", () => {
         logo = new Logo(mockActivity);
     });
 
-    test("calls function code with correct arguments and returns result", () => {
-        const pluginFn = jest.fn(() => 42);
-        const result = logo.safePluginExecute(pluginFn, logo, 0, 0, null);
-        expect(pluginFn).toHaveBeenCalledWith(logo, 0, 0, null);
+    afterEach(() => jest.restoreAllMocks());
+
+    test("executes function code and returns its result", () => {
+        const result = logo.safePluginExecute(() => 42, logo, 0, 0, null);
         expect(result).toBe(42);
     });
 
@@ -1720,7 +1720,6 @@ describe("Logo safePluginExecute", () => {
         const result = logo.safePluginExecute(crashFn, logo, 0, 0, null);
         expect(errorSpy).toHaveBeenCalled();
         expect(result).toBeUndefined();
-        errorSpy.mockRestore();
     });
 
     test("returns undefined for non-string non-function code", () => {
@@ -1790,7 +1789,6 @@ describe("Logo safePluginExecute", () => {
         const result = logo.safePluginExecute("eval('alert(1)')", logo, 0, 0, null);
         expect(warnSpy).toHaveBeenCalledWith(expect.stringContaining("Blocked"), expect.anything());
         expect(result).toBeUndefined();
-        warnSpy.mockRestore();
     });
 });
 
@@ -1811,6 +1809,8 @@ describe("Logo parseArg additional edge cases", () => {
         logo.inStatusMatrix = false;
     });
 
+    afterEach(() => jest.restoreAllMocks());
+
     test("dectofrac with null child block shows NOINPUTERRORMSG and sets value to 0", () => {
         logo.blockList = [
             { name: "print", connections: [null, 1] },
@@ -1897,9 +1897,12 @@ describe("Logo parseArg additional edge cases", () => {
         expect(logo.returns[0].length).toBe(0);
     });
 
-    test("unknown anyout block in evalArgDict invokes safePluginExecute", () => {
-        logo.evalArgDict = { customplugin: jest.fn() };
-        logo.safePluginExecute = jest.fn();
+    test("evalArgDict plugin result is reflected in parseArg return value", () => {
+        logo.evalArgDict = {
+            customplugin: (l, _turtle, blk) => {
+                l.blockList[blk].value = 555;
+            }
+        };
         logo.blockList = [
             {
                 name: "customplugin",
@@ -1909,16 +1912,8 @@ describe("Logo parseArg additional edge cases", () => {
                 isValueBlock: () => false
             }
         ];
-        logo.parseArg(logo, 0, 0, null, null);
-        expect(logo.safePluginExecute).toHaveBeenCalledWith(
-            logo.evalArgDict.customplugin,
-            logo,
-            0,
-            0,
-            null,
-            null,
-            tur
-        );
+        const result = logo.parseArg(logo, 0, 0, null, null);
+        expect(result).toBe(555);
     });
 
     test("unknown anyout block not in evalArgDict logs console error", () => {
@@ -1935,7 +1930,6 @@ describe("Logo parseArg additional edge cases", () => {
         ];
         logo.parseArg(logo, 0, 0, null, null);
         expect(errorSpy).toHaveBeenCalled();
-        errorSpy.mockRestore();
     });
 });
 
@@ -2087,6 +2081,8 @@ describe("Logo doStopTurtles timer cleanup", () => {
         logo._restoreConnections = jest.fn();
     });
 
+    afterEach(() => jest.restoreAllMocks());
+
     test("clears delayTimeout for turtles that have a pending timer", () => {
         const clearTimeoutSpy = jest.spyOn(global, "clearTimeout").mockImplementation(() => {});
         tur.delayTimeout = 456;
@@ -2095,7 +2091,6 @@ describe("Logo doStopTurtles timer cleanup", () => {
 
         expect(clearTimeoutSpy).toHaveBeenCalledWith(456);
         expect(tur.delayTimeout).toBeNull();
-        clearTimeoutSpy.mockRestore();
     });
 
     test("timerManager.clearAll is invoked during stop", () => {
@@ -2104,7 +2099,6 @@ describe("Logo doStopTurtles timer cleanup", () => {
         logo.doStopTurtles();
 
         expect(clearAllSpy).toHaveBeenCalled();
-        clearAllSpy.mockRestore();
     });
 
     test("logs debug message when timerManager cancels pending timers", () => {
@@ -2114,7 +2108,6 @@ describe("Logo doStopTurtles timer cleanup", () => {
         logo.doStopTurtles();
 
         expect(debugSpy).toHaveBeenCalledWith(expect.stringContaining("cancelled"));
-        debugSpy.mockRestore();
     });
 });
 
@@ -2145,13 +2138,16 @@ describe("Logo runLogoCommands additional coverage", () => {
     });
 
     test("executes each evalOnStartList plugin at run startup", () => {
-        logo.evalOnStartList = { hook1: jest.fn(), hook2: jest.fn() };
-        logo.safePluginExecute = jest.fn();
+        const effects = [];
+        logo.evalOnStartList = {
+            hook1: () => effects.push("hook1"),
+            hook2: () => effects.push("hook2")
+        };
 
         logo.runLogoCommands(null, null);
 
-        expect(logo.safePluginExecute).toHaveBeenCalledWith(logo.evalOnStartList.hook1, logo);
-        expect(logo.safePluginExecute).toHaveBeenCalledWith(logo.evalOnStartList.hook2, logo);
+        expect(effects).toContain("hook1");
+        expect(effects).toContain("hook2");
     });
 
     test("removes existing turtle listeners from stage before running", () => {
@@ -2212,9 +2208,9 @@ describe("Logo runFromBlockNow additional coverage", () => {
         expect(logo.stopTurtle).toBe(true);
     });
 
-    test("evalFlowDict plugin is called for matching flow block", () => {
-        const pluginFn = jest.fn();
-        logo.evalFlowDict = { widgetblock: pluginFn };
+    test("evalFlowDict plugin executes when block name matches", () => {
+        const effects = [];
+        logo.evalFlowDict = { widgetblock: () => effects.push("ran") };
         logo.pluginReturnValue = null;
         logo.blockList = [
             {
@@ -2228,7 +2224,7 @@ describe("Logo runFromBlockNow additional coverage", () => {
 
         logo.runFromBlockNow(logo, 0, 0, 0, null);
 
-        expect(pluginFn).toHaveBeenCalled();
+        expect(effects).toContain("ran");
     });
 
     test("arg block with null value displays 'null block value' message", () => {
@@ -2250,17 +2246,6 @@ describe("Logo runFromBlockNow additional coverage", () => {
     });
 });
 
-// ─── processSpeak smoke test ──────────────────────────────────────────────────
-
-describe("Logo processSpeak", () => {
-    test("does not throw for any text input", () => {
-        const logo = new Logo(_buildCovActivity());
-        expect(() => logo.processSpeak("hello world")).not.toThrow();
-        expect(() => logo.processSpeak("")).not.toThrow();
-        expect(() => logo.processSpeak(null)).not.toThrow();
-    });
-});
-
 // ─── constructor compatibility edge cases ─────────────────────────────────────
 
 describe("Logo constructor compatibility", () => {