test(logo): reduce impl-detail coupling and remove setup duplication

- Remove dead-code spread in createMockTurtle
- Add createTwoTurtleActivity helper; apply in synth-lifecycle,
  doStopTurtles, and runLogoCommands beforeEach blocks
- Consolidate 8 single-assertion Logo Constants tests into 2 grouped tests
- Fix runFromBlock beforeEach to use setupLogoEnv() instead of manual setup
- Replace logo._notation private-field assertions with logo.notation getter
- Remove turtle.delayTimeout state assertion after doStopTurtles (clearTimeout
  call is the observable behaviour)
- Remove turtle0.listeners state assertion after runLogoCommands (stage
  removeEventListener is the observable behaviour)
- Replace logo.blockTimings private-field assertions in profiling tests
  with performanceTracker.enterBlock call-count assertions
- Drop redundant null assignments in clearTurtleRun and Transport scheduling
  tests (createMockTurtle already sets these to null)
- Add jest.restoreAllMocks() to timerManager afterEach

Signed-off-by: Vanshika <pahalvanshikaa@gmail.com>

Author: vanshika2720

js/__tests__/logo.test.js

@@ -239,7 +239,6 @@ function createMockTurtle(overrides = {}) {
         doShowImage: jest.fn(),
         doShowURL: jest.fn(),
         doShowText: jest.fn(),
-        ...(overrides.queue !== undefined ? {} : {}),
         // Re-apply scalar overrides that would have been clobbered by the spread above
         ...Object.fromEntries(
             Object.entries(overrides).filter(([k]) => k !== "singer" && k !== "painter")
@@ -302,6 +301,16 @@ function createMockActivity(turtle) {
     };
 }
 
+function createTwoTurtleActivity(turtle0, turtle1) {
+    const activity = createMockActivity(turtle0);
+    activity.turtles.turtleList = [turtle0, turtle1];
+    activity.turtles.ithTurtle = jest.fn(i => (String(i) === "1" ? turtle1 : turtle0));
+    activity.turtles.getTurtle = jest.fn(i => (String(i) === "1" ? turtle1 : turtle0));
+    activity.turtles.getTurtleCount = jest.fn(() => 2);
+    activity.turtles.turtleCount = jest.fn(() => 2);
+    return activity;
+}
+
 // Centralised per-test environment reset – call at the top of every beforeEach.
 // Avoids repeating six identical lines in every describe block.
 function setupLogoEnv({ withFlute = false } = {}) {
@@ -371,35 +380,17 @@ describe("Queue Class", () => {
 // ─── Logo constants ───────────────────────────────────────────────────────────
 
 describe("Logo Constants", () => {
-    test("DEFAULTVOLUME is 50", () => {
+    test("audio and timing constants have correct values", () => {
         expect(DEFAULTVOLUME).toBe(50);
-    });
-
-    test("PREVIEWVOLUME is 80", () => {
         expect(PREVIEWVOLUME).toBe(80);
-    });
-
-    test("DEFAULTDELAY is 500", () => {
         expect(DEFAULTDELAY).toBe(500);
-    });
-
-    test("OSCVOLUMEADJUSTMENT is 1.5", () => {
         expect(OSCVOLUMEADJUSTMENT).toBe(1.5);
     });
 
-    test("TONEBPM is 240", () => {
+    test("playback and execution constants have correct values", () => {
         expect(TONEBPM).toBe(240);
-    });
-
-    test("TARGETBPM is 90", () => {
         expect(TARGETBPM).toBe(90);
-    });
-
-    test("TURTLESTEP is -1", () => {
         expect(TURTLESTEP).toBe(-1);
-    });
-
-    test("NOTEDIV is 8", () => {
         expect(NOTEDIV).toBe(8);
     });
 
@@ -464,7 +455,7 @@ describe("Logo constructor", () => {
     });
 
     test("initializes notation object", () => {
-        expect(logo._notation).toBeDefined();
+        expect(logo.notation).toBeDefined();
     });
 
     test("initializes synth", () => {
@@ -554,7 +545,8 @@ describe("Logo getters and setters", () => {
     });
 
     test("notation getter returns notation object", () => {
-        expect(logo.notation).toBe(logo._notation);
+        expect(logo.notation).toBeDefined();
+        expect(logo.notation).not.toBeNull();
     });
 
     test("setCameraID sets cameraID property", () => {
@@ -865,12 +857,7 @@ describe("Logo synth lifecycle", () => {
         setupLogoEnv({ withFlute: true });
         turtle0 = createMockTurtle();
         turtle1 = createMockTurtle();
-        mockActivity = createMockActivity(turtle0);
-        mockActivity.turtles.turtleList = [turtle0, turtle1];
-        mockActivity.turtles.ithTurtle = jest.fn(i => (String(i) === "1" ? turtle1 : turtle0));
-        mockActivity.turtles.getTurtle = jest.fn(i => (String(i) === "1" ? turtle1 : turtle0));
-        mockActivity.turtles.getTurtleCount = jest.fn(() => 2);
-        mockActivity.turtles.turtleCount = jest.fn(() => 2);
+        mockActivity = createTwoTurtleActivity(turtle0, turtle1);
         logo = new Logo(mockActivity);
     });
 
@@ -972,7 +959,6 @@ describe("Logo doStopTurtles", () => {
         logo.doStopTurtles();
 
         expect(clearTimeoutSpy).toHaveBeenCalledWith(TIMER_ID);
-        expect(turtle.delayTimeout).toBeNull();
     });
 
     test("timerManager.clearAll is invoked during stop", () => {
@@ -996,16 +982,7 @@ describe("Logo doStopTurtles", () => {
             global.instrumentsEffects = { 0: {}, 1: {} };
             turtle0 = createMockTurtle();
             turtle1 = createMockTurtle();
-            twoTurtleActivity = createMockActivity(turtle0);
-            twoTurtleActivity.turtles.turtleList = [turtle0, turtle1];
-            twoTurtleActivity.turtles.ithTurtle = jest.fn(i =>
-                String(i) === "1" ? turtle1 : turtle0
-            );
-            twoTurtleActivity.turtles.getTurtle = jest.fn(i =>
-                String(i) === "1" ? turtle1 : turtle0
-            );
-            twoTurtleActivity.turtles.getTurtleCount = jest.fn(() => 2);
-            twoTurtleActivity.turtles.turtleCount = jest.fn(() => 2);
+            twoTurtleActivity = createTwoTurtleActivity(turtle0, turtle1);
             twoTurtleActivity.showBlocksAfterRun = true;
             logo = new Logo(twoTurtleActivity);
             logo.deps.instruments = { 0: { flute: {} }, 1: { piano: {} } };
@@ -1105,12 +1082,7 @@ describe("Logo runLogoCommands", () => {
         global.document.body.style.cursor = "pointer";
         turtle0 = createMockTurtle();
         turtle1 = createMockTurtle();
-        mockActivity = createMockActivity(turtle0);
-        mockActivity.turtles.turtleList = [turtle0, turtle1];
-        mockActivity.turtles.ithTurtle = jest.fn(i => (String(i) === "1" ? turtle1 : turtle0));
-        mockActivity.turtles.getTurtle = jest.fn(i => (String(i) === "1" ? turtle1 : turtle0));
-        mockActivity.turtles.getTurtleCount = jest.fn(() => 2);
-        mockActivity.turtles.turtleCount = jest.fn(() => 2);
+        mockActivity = createTwoTurtleActivity(turtle0, turtle1);
         logo = new Logo(mockActivity);
         mockActivity.logo = logo;
         logo.prepSynths = jest.fn();
@@ -1195,7 +1167,6 @@ describe("Logo runLogoCommands", () => {
             oldListener,
             false
         );
-        expect(turtle0.listeners).toEqual({});
     });
 
     test("drum block is included in startBlocks", () => {
@@ -1257,13 +1228,8 @@ describe("Logo runFromBlock", () => {
     let savedTone;
 
     beforeEach(() => {
-        jest.clearAllMocks();
+        setupLogoEnv({ withFlute: true });
         savedTone = global.Tone;
-        global.instruments = { 0: { flute: {} } };
-        global.instrumentsFilters = { 0: { flute: ["lp"] } };
-        global.instrumentsEffects = { 0: { flute: { reverb: 0.5 } } };
-        global.window.widgetWindows = { isOpen: jest.fn(() => false) };
-        global.document.getElementById = jest.fn(() => ({ style: { color: "" } }));
         turtle0 = createMockTurtle();
         mockActivity = createMockActivity(turtle0);
         logo = new Logo(mockActivity);
@@ -1336,8 +1302,6 @@ describe("Logo runFromBlock", () => {
             logo.stopTurtle = false;
             turtle0.waitTime = 200;
             turtle0._transportTime = 10;
-            turtle0.delayParameters = null;
-            turtle0._transportEventId = null;
 
             logo.runFromBlock(logo, 0, 3, 1, "x");
 
@@ -1483,7 +1447,7 @@ describe("Logo runFromBlockNow", () => {
 
             logo.runFromBlockNow(logo, 0, 0, 0, null);
 
-            expect(logo.blockTimings).toBeUndefined();
+            expect(global.performanceTracker.enterBlock).not.toHaveBeenCalled();
         });
 
         test("profiling on increments call count", () => {
@@ -1517,7 +1481,7 @@ describe("Logo runFromBlockNow", () => {
 
             logo.runFromBlockNow(logo, 0, 0, 0, null);
 
-            expect(logo.blockTimings.noop.calls).toBe(1);
+            expect(global.performanceTracker.enterBlock).toHaveBeenCalledTimes(1);
         });
     });
 
@@ -1695,7 +1659,6 @@ describe("Logo clearTurtleRun", () => {
                     set seconds(v) {}
                 }
             };
-            turtle0.delayTimeout = null;
             turtle0._transportEventId = "evt-3";
             turtle0.delayParameters = { blk: 7, flow: 0, arg: null };
             turtle0._transportTime = 50;
@@ -1708,9 +1671,6 @@ describe("Logo clearTurtleRun", () => {
     });
 
     test("is no-op when no pending delay or Transport event", () => {
-        turtle0.delayTimeout = null;
-        turtle0._transportEventId = null;
-
         logo.clearTurtleRun(0);
 
         expect(logo.runFromBlockNow).not.toHaveBeenCalled();
@@ -2115,6 +2075,7 @@ describe("Logo timerManager getter and shim", () => {
 
     afterEach(() => {
         jest.useRealTimers();
+        jest.restoreAllMocks();
     });
 
     test("timerManager exposes clearAll, getStats, and setGuardedTimeout", () => {