Skip to content

Commit ec89552

Browse files
fix: use setControlPoint1/2 correctly, remove non-existent doControlPoint calls
1 parent d634ee6 commit ec89552

2 files changed

Lines changed: 10 additions & 10 deletions

File tree

js/blocks/GraphicsBlocks.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -449,7 +449,7 @@ function setupGraphicsBlocks(activity) {
449449
} else if (tur.singer.inNoteBlock.length > 0) {
450450
tur.singer.embeddedGraphics[last(tur.singer.inNoteBlock)].push(blk);
451451
} else {
452-
tur.painter.doControlPoint2(args[0], args[1]);
452+
tur.painter.setControlPoint2(args);
453453
}
454454
}
455455
}
@@ -500,7 +500,7 @@ function setupGraphicsBlocks(activity) {
500500
} else if (tur.singer.inNoteBlock.length > 0) {
501501
tur.singer.embeddedGraphics[last(tur.singer.inNoteBlock)].push(blk);
502502
} else {
503-
tur.painter.doControlPoint1(args[0], args[1]);
503+
tur.painter.setControlPoint1(args);
504504
}
505505
}
506506
}

js/blocks/__tests__/GraphicsBlocks.additional.test.js

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -66,8 +66,8 @@ function buildSetup() {
6666
doArc: jest.fn(),
6767
doForward: jest.fn(),
6868
doRight: jest.fn(),
69-
doControlPoint1: jest.fn(),
70-
doControlPoint2: jest.fn(),
69+
setControlPoint1: jest.fn(),
70+
setControlPoint2: jest.fn(),
7171
penState: true,
7272
wrap: false
7373
},
@@ -231,18 +231,18 @@ describe("GraphicsBlocks — Additional Coverage", () => {
231231
expect(setup.activity.blocks.controlpoint1).toBeDefined();
232232
});
233233

234-
test("ControlPoint1Block flow calls doControlPoint1", () => {
234+
test("ControlPoint1Block flow calls setControlPoint1", () => {
235235
const Block = setup.activity.blocks.controlpoint1;
236236
const block = new Block();
237237
block.flow([50, 60], setup.logo, setup.turtle, 1);
238-
expect(setup.turtleObj.painter.doControlPoint1).toHaveBeenCalledWith(50, 60);
238+
expect(setup.turtleObj.painter.setControlPoint1).toHaveBeenCalledWith([50, 60]);
239239
});
240240

241241
test("ControlPoint1Block flow with zero values", () => {
242242
const Block = setup.activity.blocks.controlpoint1;
243243
const block = new Block();
244244
block.flow([0, 0], setup.logo, setup.turtle, 1);
245-
expect(setup.turtleObj.painter.doControlPoint1).toHaveBeenCalledWith(0, 0);
245+
expect(setup.turtleObj.painter.setControlPoint1).toHaveBeenCalledWith([0, 0]);
246246
});
247247
});
248248

@@ -258,18 +258,18 @@ describe("GraphicsBlocks — Additional Coverage", () => {
258258
expect(setup.activity.blocks.controlpoint2).toBeDefined();
259259
});
260260

261-
test("ControlPoint2Block flow calls doControlPoint2", () => {
261+
test("ControlPoint2Block flow calls setControlPoint2", () => {
262262
const Block = setup.activity.blocks.controlpoint2;
263263
const block = new Block();
264264
block.flow([70, 80], setup.logo, setup.turtle, 1);
265-
expect(setup.turtleObj.painter.doControlPoint2).toHaveBeenCalledWith(70, 80);
265+
expect(setup.turtleObj.painter.setControlPoint2).toHaveBeenCalledWith([70, 80]);
266266
});
267267

268268
test("ControlPoint2Block flow with negative values", () => {
269269
const Block = setup.activity.blocks.controlpoint2;
270270
const block = new Block();
271271
block.flow([-30, -40], setup.logo, setup.turtle, 1);
272-
expect(setup.turtleObj.painter.doControlPoint2).toHaveBeenCalledWith(-30, -40);
272+
expect(setup.turtleObj.painter.setControlPoint2).toHaveBeenCalledWith([-30, -40]);
273273
});
274274
});
275275

0 commit comments

Comments
 (0)