Notes / Questions

[ndushay]

• shouldn't some of the settings live with the gem?
• there's no language builder?
• marc_country.rb feels like it belongs in a config folder but whatever
• workflow migrated to top level workflow_solr_doc and workflow_field?
• is there an orcid_builder in cocina-models? (how many places does it exist? Peter might be helpful).
• (ditto for some of the other builders, maybe)

README would be improved with "how to use this" example. Once you figure that out.

[ndushay]

tagging @justinlittman

[justinlittman]

shouldn't some of the settings live with the gem?

This gem only does the building, not the indexing. The only thing that requires configuration is the workflow client, but it is easier to just inject it.

there's no language builder?

It isn't used anywhere.

workflow migrated to top level workflow_solr_doc and workflow_field?

Migrating from a rails structure (with services and models) is imperfect. I don't feel strongly where these go.

is there an orcid_builder in cocina-models?

Maybe, but I'm not trying to refactor here.

README would be improved with "how to use this" example

There is a usage section.