Merge pull request #174 from sul-dlss/fix_registration

Handle bulk action forms that do not have source properties.

Author: aaron-collier

app/controllers/bulk_actions/bulk_action_application_controller.rb

@@ -9,7 +9,7 @@ class BulkActionApplicationController < ApplicationController
 
     def new
       @bulk_action_form = form_class.new
-      @bulk_action_form.source = 'results' if @last_search_form.present?
+      @bulk_action_form.source = 'results' if @last_search_form.present? && @bulk_action_form.respond_to?(:source=)
     end
 
     def create

spec/requests/bulk_actions/register_spec.rb

@@ -0,0 +1,25 @@
+# frozen_string_literal: true
+
+require 'rails_helper'
+
+RSpec.describe 'Register bulk action' do
+  let(:user) { create(:user) }
+
+  before do
+    sign_in user
+  end
+
+  describe 'GET new' do
+    context 'when a last search cookie is present' do
+      before do
+        cookies[:last_search] = signed_last_search_cookie
+      end
+
+      it 'renders successfully without error' do
+        get new_bulk_actions_register_path
+
+        expect(response).to have_http_status(:ok)
+      end
+    end
+  end
+end

spec/support/cookie_support.rb

@@ -1,12 +1,14 @@
 # frozen_string_literal: true
 
-def set_last_search_cookie(search_form: SearchForm.new(query: 'test', page: 5), total_results: 10) # rubocop:disable Metrics/AbcSize
+def signed_last_search_cookie(search_form: SearchForm.new(query: 'test', page: 5), total_results: 10)
+  Rails.application
+       .message_verifier(Rails.application.config.action_dispatch.signed_cookie_salt)
+       .generate({ form: search_form.attributes, total_results: })
+end
+
+def set_last_search_cookie(search_form: SearchForm.new(query: 'test', page: 5), total_results: 10)
   visit root_path
-  signed_value = Rails.application
-                      .message_verifier(Rails.application.config.action_dispatch.signed_cookie_salt)
-                      .generate({
-                                  form: search_form.attributes, total_results:
-                                })
+  signed_value = signed_last_search_cookie(search_form:, total_results:)
   page.driver.browser.manage.add_cookie(
     name: :last_search,
     value: signed_value,