Skip to content

Commit 250edd6

Browse files
committed
Upgrade to blacklight 9
1 parent e905f73 commit 250edd6

44 files changed

Lines changed: 202 additions & 220 deletions

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

.rubocop_todo.yml

Lines changed: 8 additions & 21 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Gemfile

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -41,9 +41,8 @@ gem 'view_component'
4141
gem 'zip_tricks'
4242

4343
# Stanford related gems
44-
gem 'blacklight', '~> 7.41'
45-
# pinned because 6.7.0 is effectively coupled to BL >= 8.3.0 and Argo hasn't been updated to BL8 yet
46-
gem 'blacklight-hierarchy', '~> 6.6.0'
44+
gem 'blacklight', '~> 9.0'
45+
gem 'blacklight-hierarchy', '~> 6.9'
4746
gem 'cocina_display', '~> 2'
4847
gem 'dor-services-client', '~> 15.1'
4948
gem 'druid-tools'

Gemfile.lock

Lines changed: 7 additions & 9 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# frozen_string_literal: true
22

33
class ConstraintComponent < Blacklight::ConstraintComponent
4-
def initialize(facet_item_presenter:, classes: 'filter', layout: ConstraintLayoutComponent)
4+
def initialize(facet_item_presenter:, classes: ['filter'], layout: ConstraintLayoutComponent)
55
super
66
end
77
end

app/components/date_choice_facet_component.html.erb

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,15 +3,15 @@
33
<%= @facet_field.label %>
44
<% end %>
55
<% component.with_body do %>
6-
<%= render Blacklight::FacetFieldListComponent.new(facet_field: @facet_field, layout: false) %>
6+
<%= render Blacklight::Facets::ListComponent.new(facet_field: @facet_field, layout: false) %>
77

88
<div data-controller="date-choice">
9-
<div class='mb-3 row'>
9+
<div class="mb-3 row">
1010
<div class="col-3"><label for="<%= @facet_field.key %>_after_datepicker">From:</label></div>
1111
<div class="col"><input id="<%= @facet_field.key %>_after_datepicker" type="date"
1212
data-date-choice-target="afterDate" data-action="change->date-choice#updateQuery" autocomplete="off"></div>
1313
</div>
14-
<div class='mb-3 row'>
14+
<div class="mb-3 row">
1515
<div class="col-3"><label for="<%= @facet_field.key %>_before_datepicker">Through:</label></div>
1616
<div class="col"><input id="<%= @facet_field.key %>_before_datepicker" type="date"
1717
data-date-choice-target="beforeDate" data-action="change->date-choice#updateQuery" autocomplete="off"></div>

app/components/date_choice_facet_component.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# frozen_string_literal: true
22

3-
class DateChoiceFacetComponent < Blacklight::FacetFieldListComponent
3+
class DateChoiceFacetComponent < Blacklight::Facets::ListComponent
44
def search_params
55
@facet_field.search_state.params_for_search.except(:page, :utf8)
66
end

app/components/document_component.rb

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,8 @@ def initialize(document: nil, **kwargs)
66
end
77

88
def child_component
9+
return super unless @view_context.action_name == 'show' && @view_context.controller_name == 'catalog'
10+
911
component_class.new(presenter: @presenter)
1012
end
1113

app/components/document_title_component.html.erb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,14 +6,14 @@
66
<%= version_banner %>
77
<% if show_latest_link? %>
88
<div class="text-body">
9-
<%= link_to('View latest version', solr_document_path(@document.id)) %>
9+
<%= link_to('View latest version', solr_document_path(@presenter.document.id)) %>
1010
</div>
1111
<% end %>
1212
</div>
1313
</div>
1414
<% end %>
1515
<div class="row">
16-
<%= render OpenCloseComponent.new(id: @document.id) if helpers.can?(:update, @presenter.cocina) && !version_or_user_version_view? %>
16+
<%= render OpenCloseComponent.new(id: @presenter.document.id) if helpers.can?(:update, @presenter.cocina) && !version_or_user_version_view? %>
1717

1818
<%= content_tag @as, class: @classes do %>
1919
<%= title -%>

app/components/document_title_component.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,9 @@
22

33
class DocumentTitleComponent < Blacklight::DocumentTitleComponent
44
def object_type_label
5-
return 'apo' if @document.admin_policy?
5+
return 'apo' if @presenter.document.admin_policy?
66

7-
@document.object_type
7+
@presenter.document.object_type
88
end
99

1010
def object_type_class

app/components/search_navbar_component.rb

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,6 @@
11
# frozen_string_literal: true
22

3-
# @TODO after upgrading to BL 8, inherit from Blacklight::SearchNavbarComponent and remove most of it except for
4-
# "container_classes"
5-
class SearchNavbarComponent < Blacklight::Component
6-
def initialize(blacklight_config:)
7-
@blacklight_config = blacklight_config
8-
end
9-
10-
attr_reader :blacklight_config
11-
3+
class SearchNavbarComponent < Blacklight::SearchNavbarComponent
124
def container_classes
135
'container'
146
end
@@ -22,7 +14,7 @@ def search_bar_component
2214
url: helpers.search_action_url,
2315
advanced_search_url: helpers.search_action_url(action: 'advanced_search'),
2416
params: helpers.search_state.params_for_search.except(:qt),
25-
autocomplete_path: suggest_index_catalog_path
17+
autocomplete_path: helpers.suggest_index_catalog_path
2618
)
2719
end
2820

0 commit comments

Comments
 (0)