Adds URI validation.

closes #901

Author: justinlittman

lib/cocina/models/validators/json_schema_validator.rb

@@ -36,7 +36,8 @@ def self.validate(...)
         # @return [JSONSchema validator] a cached per-definition validator
         def self.validator_for(def_name)
           @validators ||= {}
-          @validators[def_name] ||= JSONSchema.validator_for({ '$ref' => "#/$defs/#{def_name}", '$defs' => document['$defs'] })
+          schema = { '$ref' => "#/$defs/#{def_name}", '$defs' => document['$defs'] }
+          @validators[def_name] ||= JSONSchema.validator_for(schema, validate_formats: true)
         end
 
         # @return [Hash] a hash representation of the schema.json document

schema.json

@@ -1126,7 +1126,8 @@
             },
             "uri": {
               "description": "URI value of the descriptive element.",
-              "type": "string"
+              "type": "string",
+              "format": "uri"
             },
             "standard": {
               "$ref": "#/$defs/Standard"
@@ -1416,7 +1417,8 @@
         },
         "uri": {
           "description": "URI for the standard or encoding.",
-          "type": "string"
+          "type": "string",
+          "format": "uri"
         },
         "value": {
           "description": "String describing the standard or encoding.",
@@ -1956,7 +1958,8 @@
         },
         "uri": {
           "description": "URI value of the descriptive element.",
-          "type": "string"
+          "type": "string",
+          "format": "uri"
         },
         "value": {
           "description": "Value of the descriptive element.",
@@ -3075,7 +3078,8 @@
         },
         "uri": {
           "description": "URI for the value source.",
-          "type": "string"
+          "type": "string",
+          "format": "uri"
         },
         "value": {
           "description": "String describing the value source.",
@@ -3122,7 +3126,8 @@
         },
         "uri": {
           "description": "URI for the standard or encoding.",
-          "type": "string"
+          "type": "string",
+          "format": "uri"
         },
         "value": {
           "description": "String describing the standard or encoding.",

spec/cocina/models/description_spec.rb

@@ -94,6 +94,18 @@
     end
   end
 
+  context 'with an invalid uri' do
+    let(:properties) do
+      JSON.parse(File.read('spec/fixtures/description/etd.json')).tap do |props|
+        props['contributor'].first['role'].first['uri'] = 'not a uri'
+      end
+    end
+
+    it 'raises' do
+      expect { item }.to raise_error(Cocina::Models::ValidationError)
+    end
+  end
+
   describe 'introspecting' do
     it 'is possible to get the nodes from the schema' do
       # We use this to determine whether the paths in the descriptive spreadsheet are valid