Make description required for AdminPolicy

Author: lwrubel

lib/cocina/models/admin_policy.rb

@@ -18,7 +18,7 @@ class AdminPolicy < Struct
       attribute :version, Types::Strict::Integer
       # Administrative properties for an AdminPolicy
       attribute(:administrative, AdminPolicyAdministrative.default { AdminPolicyAdministrative.new })
-      attribute? :description, Description.optional
+      attribute(:description, Description.default { Description.new })
     end
   end
 end

lib/cocina/models/admin_policy_with_metadata.rb

@@ -19,7 +19,7 @@ class AdminPolicyWithMetadata < Struct
       attribute :version, Types::Strict::Integer
       # Administrative properties for an AdminPolicy
       attribute(:administrative, AdminPolicyAdministrative.default { AdminPolicyAdministrative.new })
-      attribute? :description, Description.optional
+      attribute(:description, Description.default { Description.new })
       # When the object was created.
       attribute? :created, Types::Params::DateTime
       # When the object was modified.

schema.json

@@ -121,7 +121,8 @@
         "administrative",
         "externalIdentifier",
         "type",
-        "version"
+        "version",
+        "description"
       ]
     },
     "AdminPolicy": {

spec/cocina/generator/schema_ref_spec.rb

@@ -15,6 +15,10 @@
                                           administrative: {
                                             hasAdminPolicy: 'druid:bc123df4567',
                                             hasAgreement: 'druid:bc123df4567'
+                                          },
+                                          description: {
+                                            title: [{ value: 'An APO' }],
+                                            purl: 'https://purl.stanford.edu/bc123df4567'
                                           }
                                         }, false, false)
       end
@@ -38,23 +42,4 @@
       end
     end
   end
-
-  context 'when referenced schema is not required' do
-    # AdminPolicy.description is an optional Description
-    let(:policy) do
-      Cocina::Models::AdminPolicy.new({
-                                        externalIdentifier: 'druid:bc123df4567',
-                                        type: Cocina::Models::ObjectType.admin_policy,
-                                        version: 1,
-                                        administrative: {
-                                          hasAdminPolicy: 'druid:bc123df4567',
-                                          hasAgreement: 'druid:bc123df4567'
-                                        }
-                                      }, false, false)
-    end
-
-    it 'handles omittable' do
-      expect(policy.description).to be_nil
-    end
-  end
 end

spec/cocina/generator/schema_spec.rb

@@ -72,6 +72,10 @@
           hasAdminPolicy: 'druid:bc123df4567',
           hasAgreement: 'druid:bc123df4567',
           accessTemplate: {}
+        },
+        description: {
+          title: [{ value: 'An APO Title'}],
+          purl: 'https://purl.stanford.edu/bc123df4567'
         }
       )
     end

spec/cocina/models/validators/json_schema_validator_spec.rb

@@ -16,6 +16,10 @@
         hasAdminPolicy: 'druid:bc123df4567',
         hasAgreement: 'druid:bc123df4567',
         accessTemplate: {}
+      },
+      description: {
+        title: [{ value: 'A Title'}],
+        purl: 'https://purl.stanford.edu/bc123df4567'
       }
     }
   end
@@ -54,6 +58,10 @@
           hasAdminPolicy: 'druid:bc123df4567',
           hasAgreement: 'druid:bc123df4567',
           releaseTags: [{to: 'Searchworks', who: 'mjgiarlo', what: 'self', release: true}]
+        },
+        description: {
+          title: [{ value: 'An APO Title'}],
+          purl: 'https://purl.stanford.edu/bc123df4567'
         }
       }
     end