fix: mailer links regression (#5166)

Author: jgoux

internal/start/start.go

@@ -1283,6 +1283,7 @@ func buildGotrueEnv(dbConfig pgconn.Config) []string {
 	if len(utils.Config.Auth.Sms.TestOTP) > 0 {
 		formatMapForEnvConfig(utils.Config.Auth.Sms.TestOTP, &testOTP)
 	}
+	mailerVerifyURL := strings.TrimRight(utils.Config.AuthExternalURL(), "/") + "/verify"
 
 	return []string{
 		"API_EXTERNAL_URL=" + utils.Config.AuthExternalURL(),
@@ -1315,10 +1316,10 @@ func buildGotrueEnv(dbConfig pgconn.Config) []string {
 
 		fmt.Sprintf("GOTRUE_SMTP_MAX_FREQUENCY=%v", utils.Config.Auth.Email.MaxFrequency),
 
-		"GOTRUE_MAILER_URLPATHS_INVITE=/verify",
-		"GOTRUE_MAILER_URLPATHS_CONFIRMATION=/verify",
-		"GOTRUE_MAILER_URLPATHS_RECOVERY=/verify",
-		"GOTRUE_MAILER_URLPATHS_EMAIL_CHANGE=/verify",
+		"GOTRUE_MAILER_URLPATHS_INVITE=" + mailerVerifyURL,
+		"GOTRUE_MAILER_URLPATHS_CONFIRMATION=" + mailerVerifyURL,
+		"GOTRUE_MAILER_URLPATHS_RECOVERY=" + mailerVerifyURL,
+		"GOTRUE_MAILER_URLPATHS_EMAIL_CHANGE=" + mailerVerifyURL,
 		"GOTRUE_RATE_LIMIT_EMAIL_SENT=360000",
 
 		fmt.Sprintf("GOTRUE_EXTERNAL_PHONE_ENABLED=%v", utils.Config.Auth.Sms.EnableSignup),

internal/start/start_test.go

@@ -307,7 +307,7 @@ func TestBuildGotrueEnv(t *testing.T) {
 		utils.Config = original
 	})
 
-	t.Run("uses auth scoped external url and relative mailer paths", func(t *testing.T) {
+	t.Run("uses auth scoped external url and absolute mailer verify urls", func(t *testing.T) {
 		utils.Config = config.NewConfig()
 		utils.Config.Api.ExternalUrl = "http://127.0.0.1:54321"
 		utils.Config.Auth.ExternalUrl = "http://127.0.0.1:54321/auth/v1"
@@ -328,10 +328,10 @@ func TestBuildGotrueEnv(t *testing.T) {
 
 		assert.Equal(t, "http://127.0.0.1:54321/auth/v1", env["API_EXTERNAL_URL"])
 		assert.Equal(t, "http://127.0.0.1:54321/auth/v1", env["GOTRUE_JWT_ISSUER"])
-		assert.Equal(t, "/verify", env["GOTRUE_MAILER_URLPATHS_INVITE"])
-		assert.Equal(t, "/verify", env["GOTRUE_MAILER_URLPATHS_CONFIRMATION"])
-		assert.Equal(t, "/verify", env["GOTRUE_MAILER_URLPATHS_RECOVERY"])
-		assert.Equal(t, "/verify", env["GOTRUE_MAILER_URLPATHS_EMAIL_CHANGE"])
+		assert.Equal(t, "http://127.0.0.1:54321/auth/v1/verify", env["GOTRUE_MAILER_URLPATHS_INVITE"])
+		assert.Equal(t, "http://127.0.0.1:54321/auth/v1/verify", env["GOTRUE_MAILER_URLPATHS_CONFIRMATION"])
+		assert.Equal(t, "http://127.0.0.1:54321/auth/v1/verify", env["GOTRUE_MAILER_URLPATHS_RECOVERY"])
+		assert.Equal(t, "http://127.0.0.1:54321/auth/v1/verify", env["GOTRUE_MAILER_URLPATHS_EMAIL_CHANGE"])
 		assert.NotContains(t, env, "GOTRUE_EXTERNAL_GITHUB_REDIRECT_URI")
 	})
 
@@ -350,6 +350,7 @@ func TestBuildGotrueEnv(t *testing.T) {
 
 		assert.Equal(t, "http://127.0.0.1:54321/auth/v1", env["API_EXTERNAL_URL"])
 		assert.Equal(t, "https://issuer.example.com/auth/v1", env["GOTRUE_JWT_ISSUER"])
+		assert.Equal(t, "http://127.0.0.1:54321/auth/v1/verify", env["GOTRUE_MAILER_URLPATHS_INVITE"])
 		assert.Equal(t, "https://example.com/custom/callback", env["GOTRUE_EXTERNAL_AZURE_REDIRECT_URI"])
 	})
 }