Empty transform object routes to wrong endpoint in download() and getPublicUrl()

[oniani1]

PR #2162 fixed createSignedUrl() to properly handle empty transform objects, but the same bug is still present in download() and getPublicUrl().

Both methods use typeof options?.transform !== 'undefined' to decide whether to route through /render/image/. Since typeof {} !== 'undefined' is true, passing { transform: {} } incorrectly routes to the image render endpoint, which returns 422 for non-image files.

createSignedUrl now correctly checks:

typeof options?.transform === 'object' && options.transform !== null && Object.keys(options.transform).length > 0

download and getPublicUrl should use the same pattern.

[mandarini]

Hi @oniani1, thank you for opening this issue! 💚 You are right. The same typeof options?.transform !== 'undefined' pattern that was fixed in createSignedUrl via #2162 is still present in both download() (line 820) and getPublicUrl() (line 1009) in StorageFileApi.ts. Passing { transform: {} } to either method will incorrectly route through /render/image/ instead of /object/, causing a 422 for non-image files. Your PR #2219 applies the same Object.keys guard that createSignedUrl now uses, and the fix looks correct to me. I will take a closer look at the PR and get it reviewed.

In the meantime, the workaround is to avoid passing an empty transform object. Either omit the transform key entirely, or ensure it always has at least one property set (e.g., { transform: { width: 100 } }).

Thanks for the thorough write-up and for following up with a fix right away!