fix(chat): address fifth round of PR review feedback

- Re-add inputValue to SlashCommandPreviewPopover anchor effect deps so
  the virtual anchor re-measures when typing shifts the chip's position
- Clamp slash menu selectedIndex in onUpdate when filtered results shrink,
  matching the existing mention-menu clamping behavior
- Return true (consume event) when Enter/Tab closes empty mention popup so
  the event does not propagate to insert a paragraph break
- Mirror focus-on-dismiss effect in v2 workspace ChatInputFooter so the
  editor regains focus after the question overlay unmounts
- Fix trailing-slash paths rendering empty label in ClickableFilePath
  by using || instead of ?? for the basename fallback

Author: michalkopanski

apps/desktop/src/renderer/components/Chat/ChatInterface/components/TiptapPromptEditor/SlashCommandPreviewPopover.tsx

@@ -34,6 +34,7 @@ export function SlashCommandPreviewPopover({
 	const anchorRef = useRef<HTMLDivElement>(null);
 
 	// Position the virtual anchor over the slash-command chip in the editor.
+	// biome-ignore lint/correctness/useExhaustiveDependencies: inputValue re-measures anchor when typing shifts the chip's position
 	useLayoutEffect(() => {
 		const el = anchorRef.current;
 		if (!el) return;
@@ -52,7 +53,7 @@ export function SlashCommandPreviewPopover({
 		el.style.top = `${rect.top}px`;
 		el.style.width = `${rect.width}px`;
 		el.style.height = `${rect.height}px`;
-	}, [editor]);
+	}, [editor, inputValue]);
 
 	const slashPreviewInput = normalizeSlashPreviewInput(inputValue);
 	const parsedInput = useMemo(() => parseSlashInput(inputValue), [inputValue]);

apps/desktop/src/renderer/components/Chat/ChatInterface/components/TiptapPromptEditor/TiptapPromptEditor.tsx

@@ -297,6 +297,10 @@ export function TiptapPromptEditor({
 													...prev,
 													commands: props.items,
 													tiptapCommand: props.command,
+													selectedIndex: Math.min(
+														prev.selectedIndex,
+														Math.max(0, props.items.length - 1),
+													),
 												}
 											: null,
 									);
@@ -477,9 +481,9 @@ export function TiptapPromptEditor({
 											mention.tiptapCommand({ path: file.relativePath });
 											return true;
 										}
-										// No results — close the popup then let Enter fall through to submit
+										// No results — close the popup and consume the event
 										setMentionState(null);
-										return false;
+										return true;
 									}
 									return false;
 								},

apps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/$workspaceId/hooks/usePaneRegistry/components/ChatPane/components/WorkspaceChatInterface/components/ChatInputFooter/ChatInputFooter.tsx

@@ -3,12 +3,13 @@ import {
 	PromptInputAttachment,
 	PromptInputAttachments,
 	type PromptInputMessage,
+	usePromptInputController,
 } from "@superset/ui/ai-elements/prompt-input";
 import type { ThinkingLevel } from "@superset/ui/ai-elements/thinking-toggle";
 import type { ChatStatus, FileUIPart } from "ai";
 import type React from "react";
 import type { ReactNode } from "react";
-import { useCallback, useRef, useState } from "react";
+import { useCallback, useEffect, useRef, useState } from "react";
 import { QuestionInputOverlay } from "renderer/components/Chat/ChatInterface/components/ChatInputFooter/components/QuestionInputOverlay";
 import { IssueLinkCommand } from "renderer/components/Chat/ChatInterface/components/IssueLinkCommand";
 import { TiptapPromptEditor } from "renderer/components/Chat/ChatInterface/components/TiptapPromptEditor";
@@ -94,6 +95,19 @@ export function ChatInputFooter({
 	onQuestionCancel,
 }: ChatInputFooterProps) {
 	useFocusPromptOnPane(isFocused);
+
+	// Re-focus the editor when the question overlay dismisses.
+	const { textInput } = usePromptInputController();
+	const prevPendingQuestionRef = useRef(pendingQuestion);
+	useEffect(() => {
+		const prev = prevPendingQuestionRef.current;
+		prevPendingQuestionRef.current = pendingQuestion;
+		if (prev != null && pendingQuestion == null) {
+			const id = requestAnimationFrame(() => textInput.focus());
+			return () => cancelAnimationFrame(id);
+		}
+	}, [pendingQuestion, textInput]);
+
 	const [issueLinkOpen, setIssueLinkOpen] = useState(false);
 	const [linkedIssues, setLinkedIssues] = useState<LinkedIssue[]>([]);
 	const inputRootRef = useRef<HTMLDivElement>(null);

packages/ui/src/components/ai-elements/clickable-file-path.tsx

@@ -24,7 +24,7 @@ export function ClickableFilePath({
 	className,
 }: ClickableFilePathProps) {
 	const label =
-		display ?? (path.includes("/") ? (path.split("/").pop() ?? path) : path);
+		display ?? (path.includes("/") ? path.split("/").pop() || path : path);
 
 	if (!onOpen) {
 		return <span className={className}>{label}</span>;