feat(desktop): safer defaults for builtin terminal agent presets (#3546)

* feat(desktop): safer defaults for builtin terminal agent presets

Swap permission-bypass flags for each CLI's intended safe-but-useful
mode (claude acceptEdits, codex --full-auto, gemini auto_edit, copilot
--allow-all-tools). Drop mastracode/opencode/pi from the default seed
since they are YOLO-by-default at the CLI level; they remain available
via Quick-Add. Remove cursor-agent's --yolo suffix (silent no-op on the
real binary). Existing users are preserved — the v1
terminalPresetsInitialized guard and v2 migration marker ensure stored
commands are never rewritten.

* test(desktop): update agent-launch-request fixture for new codex default

buildPromptAgentLaunchRequest's terminal-command fixture hard-coded the
old --dangerously-bypass-approvals-and-sandbox flag. Update it to the
new --full-auto default so the test reflects the current builtin.

* fix(desktop): address reviewer feedback on safe-default flag choices

- gemini promptCommand: add --approval-mode=auto_edit so prompt/task
  launches use the same safety mode as terminal launches (flagged by
  cubic, greptile, and CodeRabbit)
- copilot: switch from --allow-all-tools to --allow-tool=write. Per
  GitHub's own docs, --allow-all-tools "allows all tools to run
  automatically without confirmation" including shell, which
  contradicts the safe-by-default claim. --allow-tool=write auto-
  approves file edits only (analog of claude's acceptEdits).
- docs: update copilot line; clarify mastracode/opencode/pi opt-in
  parentheticals so users understand why they're not auto-seeded.

Author: saddlepaddle

apps/desktop/src/shared/utils/agent-launch-request.test.ts

@@ -46,7 +46,7 @@ describe("buildPromptAgentLaunchRequest", () => {
 			agentType: "codex",
 			terminal: {
 				command:
-					'codex -c model_reasoning_effort="high" --dangerously-bypass-approvals-and-sandbox -c model_reasoning_summary="detailed" -c model_supports_reasoning_summaries=true',
+					'codex -c model_reasoning_effort="high" -c model_reasoning_summary="detailed" -c model_supports_reasoning_summaries=true --full-auto',
 			},
 		});
 	});

apps/docs/content/docs/terminal-presets.mdx

@@ -41,15 +41,17 @@ Presets are parallel by default.
 
 ## Quick-Add Templates
 
-Pre-configured presets for popular AI agents:
-
-- **amp** - `amp`
-- **claude** - `claude --dangerously-skip-permissions`
-- **codex** - Full danger mode with high reasoning effort
-- **gemini** - `gemini --yolo`
-- **pi** - `pi`
-- **cursor-agent** - Cursor AI agent
-- **opencode** - Open-source AI coding agent
+Pre-configured presets for popular AI agents. Defaults are safe-by-default — agents can read and edit files, but still prompt before running shell commands or touching files outside your workspace. Edit any preset to opt into a more permissive mode.
+
+- **amp** - `amp` (built-in permission rules auto-deny destructive ops)
+- **claude** - `claude --permission-mode acceptEdits`
+- **codex** - `codex ... --full-auto` (workspace-sandboxed)
+- **gemini** - `gemini --approval-mode=auto_edit`
+- **copilot** - `copilot --allow-tool=write`
+- **cursor-agent** - `cursor-agent` (prompts for every action)
+- **mastracode** - Mastra's coding agent (opt-in: auto-approves all actions by default at the CLI; no startup flag to restrict)
+- **opencode** - Open-source AI coding agent (opt-in: full file and shell access by default at the CLI; no startup flag to restrict)
+- **pi** - Minimal terminal coding harness (opt-in: auto-approves all actions by default at the CLI; no startup flag to restrict)
 
 ## Preset Bar
 

packages/shared/src/agent-command.test.ts

@@ -13,7 +13,7 @@ describe("buildAgentPromptCommand", () => {
 		});
 
 		expect(command).toContain(
-			"model_supports_reasoning_summaries=true -- \"$(cat <<'SUPERSET_PROMPT_12345678'",
+			"model_supports_reasoning_summaries=true --full-auto -- \"$(cat <<'SUPERSET_PROMPT_12345678'",
 		);
 		expect(command).toContain("- Only modified file: runtime.ts");
 	});
@@ -26,7 +26,7 @@ describe("buildAgentPromptCommand", () => {
 		});
 
 		expect(command).toStartWith(
-			"claude --dangerously-skip-permissions \"$(cat <<'SUPERSET_PROMPT_abcdefgh'",
+			"claude --permission-mode acceptEdits \"$(cat <<'SUPERSET_PROMPT_abcdefgh'",
 		);
 	});
 

packages/shared/src/builtin-terminal-agents.ts

@@ -62,7 +62,7 @@ export const BUILTIN_TERMINAL_AGENTS = [
 		label: "Claude",
 		description:
 			"Anthropic's coding agent for reading code, editing files, and running terminal workflows.",
-		command: "claude --dangerously-skip-permissions",
+		command: "claude --permission-mode acceptEdits",
 		includeInDefaultTerminalPresets: true,
 	}),
 	createBuiltinTerminalAgent({
@@ -80,19 +80,18 @@ export const BUILTIN_TERMINAL_AGENTS = [
 		description:
 			"OpenAI's coding agent for reading, modifying, and running code across tasks.",
 		command:
-			'codex -c model_reasoning_effort="high" --dangerously-bypass-approvals-and-sandbox -c model_reasoning_summary="detailed" -c model_supports_reasoning_summaries=true',
+			'codex -c model_reasoning_effort="high" -c model_reasoning_summary="detailed" -c model_supports_reasoning_summaries=true --full-auto',
 		promptCommand:
-			'codex -c model_reasoning_effort="high" --dangerously-bypass-approvals-and-sandbox -c model_reasoning_summary="detailed" -c model_supports_reasoning_summaries=true --',
+			'codex -c model_reasoning_effort="high" -c model_reasoning_summary="detailed" -c model_supports_reasoning_summaries=true --full-auto --',
 		includeInDefaultTerminalPresets: true,
 	}),
 	createBuiltinTerminalAgent({
 		id: "gemini",
 		label: "Gemini",
 		description:
 			"Google's open-source terminal agent for coding, problem-solving, and task work.",
-		command: "gemini --yolo",
-		promptCommand: "gemini",
-		promptCommandSuffix: "--yolo",
+		command: "gemini --approval-mode=auto_edit",
+		promptCommand: "gemini --approval-mode=auto_edit",
 		includeInDefaultTerminalPresets: true,
 	}),
 	createBuiltinTerminalAgent({
@@ -101,32 +100,28 @@ export const BUILTIN_TERMINAL_AGENTS = [
 		description:
 			"Mastra's coding agent for building, debugging, and shipping code from the terminal.",
 		command: "mastracode",
-		includeInDefaultTerminalPresets: true,
 	}),
 	createBuiltinTerminalAgent({
 		id: "opencode",
 		label: "OpenCode",
 		description: "Open-source coding agent for the terminal, IDE, and desktop.",
 		command: "opencode",
 		promptCommand: "opencode --prompt",
-		includeInDefaultTerminalPresets: true,
 	}),
 	createBuiltinTerminalAgent({
 		id: "pi",
 		label: "Pi",
 		description:
 			"Minimal terminal coding harness for flexible coding workflows.",
 		command: "pi",
-		includeInDefaultTerminalPresets: true,
 	}),
 	createBuiltinTerminalAgent({
 		id: "copilot",
 		label: "Copilot",
 		description:
 			"GitHub's coding agent for planning, editing, and building in your repo.",
-		command: "copilot --allow-all",
-		promptCommand: "copilot -i --allow-all",
-		promptCommandSuffix: "--yolo",
+		command: "copilot --allow-tool=write",
+		promptCommand: "copilot -i --allow-tool=write",
 		includeInDefaultTerminalPresets: true,
 	}),
 	createBuiltinTerminalAgent({
@@ -135,7 +130,6 @@ export const BUILTIN_TERMINAL_AGENTS = [
 		description:
 			"Cursor's coding agent for editing, running, and debugging code in parallel.",
 		command: "cursor-agent",
-		promptCommandSuffix: "--yolo",
 	}),
 ] as const;