Serve feeds via PHP

To get around nginx config.

Author: svenluijten

app/Console/Commands/GenerateFeeds.php

@@ -87,6 +87,6 @@ private function writeFeed(string $fileName, string $id, string $title, string $
         ])->render();
 
         $fs = new Filesystem;
-        $fs->put(public_path('feeds/'.$fileName), $contents);
+        $fs->put(storage_path('feeds/'.$fileName), $contents);
     }
 }

app/Http/Controllers/Feeds/Show.php

@@ -2,11 +2,17 @@
 
 namespace App\Http\Controllers\Feeds;
 
+use Illuminate\Contracts\Filesystem\FileNotFoundException;
+use Illuminate\Filesystem\Filesystem;
+
 class Show
 {
-    public function __invoke()
+    public function __invoke(string $feed, Filesystem $filesystem): string
     {
-        // 1. Every hour, a command should be fired to (re)generate the feeds.
-        // 2. This command creates static files that are served directly by NGINX.
+        try {
+            return $filesystem->get(storage_path("feeds/{$feed}.xml"));
+        } catch (FileNotFoundException $e) {
+            abort(404);
+        }
     }
 }

routes/web.php

@@ -14,12 +14,13 @@
 Route::get('/explore', Explore::class)->name('explore');
 
 Route::get('/feeds', Feeds\Index::class)->name('feeds.index');
+Route::get('/feeds/{feed}.xml', Feeds\Show::class)->name('feeds.show');
 
-Route::get('articles', Articles\Index::class)->name('articles.index');
-Route::get('articles/{article}', Articles\Show::class)->name('articles.show');
-Route::get('posts/{article}', Articles\Show::class)->name('posts.show');
+Route::get('/articles', Articles\Index::class)->name('articles.index');
+Route::get('/articles/{article}', Articles\Show::class)->name('articles.show');
+Route::get('/posts/{article}', Articles\Show::class)->name('posts.show');
 
-Route::get('concerts', Concerts\Index::class)->name('concerts.index');
-Route::get('concerts/{date}/{concert}', Concerts\Show::class)->name('concerts.show');
+Route::get('/concerts', Concerts\Index::class)->name('concerts.index');
+Route::get('/concerts/{date}/{concert}', Concerts\Show::class)->name('concerts.show');
 
 Route::get('/archive', Archive::class)->name('archive');