Rockets fired with keyboard/joystick 'Fire' control don't correctly interact with water

[bobf5]

(issue/oddity since 1996)

Original:

Normally, certain weapons impacting a water surface (bullets, missiles, grenades) create a water splashing effect. Using keyboard/joystick firing controls, only grenades interact with water correctly, whereas the other weapons treat water like solid ground. (video from original game) https://github.com/user-attachments/assets/bf305110-2c8c-44a9-8821-dc808de590db

Weapons fired with the keyboard/joystick 'Fire' control are missing interactions with water, mines, and corpses. Bullet impacts on water are implemented with 5d73b48. Mines can't be shot and detonated with keyboard/joystick firing. Corpses can't be shot unless explicitly targeted using #397.

[mefistotelis]

Partial fix in:
syndwarsfx: Use water hit effect when key shooting

But it will require remaking all shooting functions to implement this in all relevant weapons.

[bobf5]

Updated issue to document related missing functionality.

[mefistotelis]

All weapons should now correctly interact with water.

For corpses - that should really be a different issue. Corpses are things which require selection as targets, while water is just a terrain/texture type.

[bobf5]

All weapons should now correctly interact with water.

Rockets still explode on water/sludge, but otherwise this seems to be complete.

For corpses - that should really be a different issue. Corpses are things which require selection as targets, while water is just a terrain/texture type.

Right, I see now how corpse targeting works. I can foresee gameplay issues from reworking it (for NPCs, unarmed lead agent), so it's probably safer to leave that as is.

[mefistotelis]

process_rocket() needs to be remade to continue.