Commit 9556ef2
szachovy
Fix MySQL /var/log/mysql missing and password shell injection
Two bugs revealed by the first successful async run:
1. MySQL containers crash with "mkdir: cannot create directory
/var/log/mysql: Permission denied" because slow_query_log_file
references /var/log/mysql/slow-queries.log but the directory
does not exist in the base image and MySQL runs as a non-root
user. Create it with correct ownership in the Dockerfile RUN layer.
2. generate_mysql_superset_password() used string.punctuation which
includes single-quotes, backslashes, braces, and carets. These
characters break the Python string literals in run_python_container_command
where the password is interpolated with str.format() into a
single-quoted Python expression, causing a SyntaxError. Restrict
the charset to safe special characters that do not conflict with
Python or shell quoting.1 parent d40e446 commit 9556ef2
2 files changed
Lines changed: 9 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
39 | 39 | | |
40 | 40 | | |
41 | 41 | | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
42 | 50 | | |
43 | 51 | | |
44 | 52 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
65 | 65 | | |
66 | 66 | | |
67 | 67 | | |
68 | | - | |
| 68 | + | |
69 | 69 | | |
70 | 70 | | |
71 | 71 | | |
| |||
0 commit comments