Skip to content

Commit 69cec70

Browse files
authored
fix(ci): address remaining test workflow review comments
1 parent 35ccbec commit 69cec70

1 file changed

Lines changed: 11 additions & 3 deletions

File tree

.github/workflows/test.yml

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,8 @@ jobs:
4545
steps:
4646
- name: Checkout repository
4747
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6
48+
with:
49+
fetch-depth: 2
4850
- name: Detect changed paths
4951
id: filter
5052
uses: dorny/paths-filter@7b450fff21473bca461d4b92ce414b9d0420d706 # v4.0.2
@@ -351,10 +353,12 @@ jobs:
351353
# or shared Lua inputs changed. When only Python changed, `ioredis-redis`
352354
# is skipped and we still run this job (a skipped dependency is allowed, a
353355
# failed one is not).
354-
needs: [changes, ioredis-redis]
356+
needs: [changes, smoke, ioredis-redis]
355357
if: >-
358+
always() &&
356359
!cancelled() &&
357360
(needs.changes.outputs.python == 'true' || needs.changes.outputs.lua == 'true') &&
361+
needs.smoke.result == 'success' &&
358362
needs.ioredis-redis.result != 'failure' &&
359363
needs.ioredis-redis.result != 'cancelled'
360364
@@ -406,10 +410,12 @@ jobs:
406410
407411
python-dragonflydb:
408412
runs-on: ubuntu-latest
409-
needs: [changes, ioredis-redis]
413+
needs: [changes, smoke, ioredis-redis]
410414
if: >-
415+
always() &&
411416
!cancelled() &&
412417
(needs.changes.outputs.python == 'true' || needs.changes.outputs.lua == 'true') &&
418+
needs.smoke.result == 'success' &&
413419
needs.ioredis-redis.result != 'failure' &&
414420
needs.ioredis-redis.result != 'cancelled'
415421
@@ -467,10 +473,12 @@ jobs:
467473
468474
php:
469475
runs-on: ubuntu-latest
470-
needs: [changes, ioredis-redis]
476+
needs: [changes, smoke, ioredis-redis]
471477
if: >-
478+
always() &&
472479
!cancelled() &&
473480
(needs.changes.outputs.php == 'true' || needs.changes.outputs.lua == 'true') &&
481+
needs.smoke.result == 'success' &&
474482
needs.ioredis-redis.result != 'failure' &&
475483
needs.ioredis-redis.result != 'cancelled'
476484

0 commit comments

Comments
 (0)