fix(ci): address test workflow review comments

Author: Copilot

.github/workflows/test.yml

@@ -84,34 +84,34 @@ jobs:
     env:
       node-version: lts/*
       redis-version: 7-alpine
-      run-smoke: ${{ needs.changes.outputs.node == 'true' || needs.changes.outputs.lua == 'true' }}
+      run_smoke: ${{ needs.changes.outputs.node == 'true' || needs.changes.outputs.lua == 'true' }}
 
     steps:
       - name: Skip smoke run when node/lua inputs are unchanged
-        if: ${{ env.run-smoke != 'true' }}
+        if: ${{ env.run_smoke != 'true' }}
         run: echo "No node/lua changes detected; skipping smoke steps."
       - name: Checkout repository
-        if: ${{ env.run-smoke == 'true' }}
+        if: ${{ env.run_smoke == 'true' }}
         uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6
       - name: Use Node.js
-        if: ${{ env.run-smoke == 'true' }}
+        if: ${{ env.run_smoke == 'true' }}
         uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6
         with:
           node-version: ${{ env.node-version }}
           cache: 'yarn'
       - name: Start Redis
-        if: ${{ env.run-smoke == 'true' }}
+        if: ${{ env.run_smoke == 'true' }}
         uses: supercharge/redis-github-action@bc274cb7238cd63a45029db04ee48c07a72609fd # 1.8.1
         with:
           redis-version: ${{ env.redis-version }}
-      - if: ${{ env.run-smoke == 'true' }}
+      - if: ${{ env.run_smoke == 'true' }}
         run: yarn install --ignore-engines --frozen-lockfile --non-interactive
       - name: Run ESLint
-        if: ${{ env.run-smoke == 'true' }}
+        if: ${{ env.run_smoke == 'true' }}
         run: yarn lint
-      - if: ${{ env.run-smoke == 'true' }}
+      - if: ${{ env.run_smoke == 'true' }}
         run: yarn build
-      - if: ${{ env.run-smoke == 'true' }}
+      - if: ${{ env.run_smoke == 'true' }}
         run: yarn test:smoke
 
   # Primary ioredis test run on a single (current LTS) Node version.
@@ -123,7 +123,8 @@ jobs:
   # ioredis Node/Redis version matrix run in parallel.
   ioredis-redis:
     runs-on: ubuntu-latest
-    needs: smoke
+    needs: [changes, smoke]
+    if: ${{ !cancelled() && (needs.changes.outputs.node == 'true' || needs.changes.outputs.lua == 'true') }}
 
     name: testing node@${{ matrix.node-version }}, redis@${{ matrix.redis-version }}
 
@@ -347,9 +348,10 @@ jobs:
     runs-on: ubuntu-latest
     # Depend on the primary node suite (which also runs coverage) so a Node
     # test failure aborts the cross-language jobs before they consume runner
-    # time. `ioredis-redis` itself depends on `smoke`. When only Python (or
-    # nothing node-related) changed, `ioredis-redis` is skipped and we still
-    # run this job (a skipped dependency is allowed, a failed one is not).
+    # time. `ioredis-redis` itself depends on `smoke` and only runs when Node
+    # or shared Lua inputs changed. When only Python changed, `ioredis-redis`
+    # is skipped and we still run this job (a skipped dependency is allowed, a
+    # failed one is not).
     needs: [changes, ioredis-redis]
     if: >-
       !cancelled() &&