fix: resolve template validation failures in CI/CD

- Fix ai-chat-memory-template: connect init_conversation_id node to execution flow
- Fix CLI shell script generation: add missing env var warnings as proper shell comments
- Prevent stderr pollution in generated shell scripts that caused syntax errors
- Update error detection patterns to catch unbound variables and division by zero
- Templates now generate syntactically valid shell scripts with proper warning comments

Author: Tom Brandenburg

scripts/run-all-templates.sh

@@ -41,16 +41,16 @@ for template in templates/basic/*-template.yaml templates/enhanced/*-simple.yaml
                     echo "  ✅ Executed successfully"
                     success=$((success + 1))
                 # STRICT ERROR CLASSIFICATION - Zero tolerance for critical failures
-                elif grep -q "bash:.*unbound variable\|syntax error\|command not found.*get_var\|Failed to resolve template content" "$result_file"; then
+                elif grep -q "unbound variable\|syntax error\|command not found.*get_var\|Failed to resolve template content\|division by zero" "$result_file"; then
                     echo "  ❌ CRITICAL FAILURE - Shell script error detected"
                     echo "    Critical errors:"
-                    grep "bash:.*unbound variable\|syntax error\|command not found.*get_var\|Failed to resolve template content" "$result_file" | head -3 | sed 's/^/      /'
+                    grep "unbound variable\|syntax error\|command not found.*get_var\|Failed to resolve template content\|division by zero" "$result_file" | head -3 | sed 's/^/      /'
                 elif grep -q "Missing.*API.*key\|OPENAI_API_KEY.*required\|Telegram chat_id is required\|requires.*API.*key" "$result_file" && \
-                     ! grep -q "bash:.*unbound variable\|syntax error\|Failed to resolve template content" "$result_file"; then
+                     ! grep -q "unbound variable\|syntax error\|Failed to resolve template content\|division by zero" "$result_file"; then
                     echo "  ⚠️  ACCEPTABLE - Missing environment variables (template functional)"
                     success=$((success + 1))
                 elif grep -q "Mock circuit breaker.*operation failed\|Circuit breaker operation failed\|Mock circuit breaker: operation failed" "$result_file" && \
-                     ! grep -q "bash:.*unbound variable\|syntax error\|command not found.*get_var\|Failed to resolve template content" "$result_file"; then
+                     ! grep -q "unbound variable\|syntax error\|command not found.*get_var\|Failed to resolve template content\|division by zero" "$result_file"; then
                     echo "  ✅ Expected behavior - circuit breaker demonstrating failure handling"
                     success=$((success + 1))
                 else

src/cli/index.ts

@@ -109,21 +109,25 @@ async function compileCommand(
       console.error('');
     }
 
-    // Check for missing environment variables and warn user
+    // Check for missing environment variables and add as comments to script
     const missingEnvVars = scanMissingEnvironmentVariables(parseResult.workflow);
+    let finalScript = generateResult.script;
     if (missingEnvVars.length > 0) {
-      console.error('⚠️  Missing environment variables:');
-      missingEnvVars.forEach(varName => {
-        console.error(`   → ${varName} (consider setting this before running the script)`);
-      });
-      console.error('');
+      const warnings = [
+        '# ⚠️  Missing environment variables:',
+        ...missingEnvVars.map(
+          varName => `#    → ${varName} (consider setting this before running the script)`
+        ),
+        '#',
+      ];
+      finalScript = warnings.join('\n') + '\n' + finalScript;
     }
 
     // Dry-run mode: validate and compile but don't output
     if (options.dryRun) {
       const nodeCount = parseResult.workflow?.graph?.nodes?.length || 0;
       const edgeCount = parseResult.workflow?.graph?.edges?.length || 0;
-      const scriptLines = generateResult.script.split('\n').length;
+      const scriptLines = finalScript.split('\n').length;
 
       console.log(`✅ Dry-run successful for ${workflowFile}`);
       console.log(`   Nodes: ${nodeCount}, Edges: ${edgeCount}`);
@@ -143,10 +147,10 @@ async function compileCommand(
 
     // Output to file or stdout
     if (options.output) {
-      await writeScriptToFile(generateResult.script, options.output);
+      await writeScriptToFile(finalScript, options.output);
     } else {
       // Output to stdout (jq-like behavior)
-      console.log(generateResult.script);
+      console.log(finalScript);
     }
   } catch (error) {
     handleError(error, 'Compilation');

templates/advanced/ai-workflows/ai-chat-memory-template.yaml

@@ -360,6 +360,8 @@ graph:
 
   edges:
     - source: 'start'
+      target: 'init_conversation_id'
+    - source: 'init_conversation_id'
       target: 'initialize_memory_system'
     - source: 'initialize_memory_system'
       target: 'load_conversation_history'