Merge pull request #3 from tbrandenburg/codex/add-bash-n-syntax-checking-to-compile-command

Author: tbrandenburg

src/cli/index.test.ts

@@ -107,6 +107,21 @@ describe('CLI Output Option', () => {
   });
 });
 
+describe('CLI Bash Syntax Validation', () => {
+  it('should fail compilation when generated script has bash syntax errors', () => {
+    const command = 'node dist/cli/index.js compile tests/workflows/invalid-bash-test.yaml';
+
+    try {
+      execSync(command, { encoding: 'utf8' });
+      expect(false).toBe(true);
+    } catch (error: any) {
+      const errorOutput = error.stderr?.toString() ?? error.stdout?.toString() ?? error.message;
+      expect(errorOutput).toContain('Compilation failed:');
+      expect(errorOutput).toContain('Bash syntax validation failed');
+    }
+  });
+});
+
 describe('CLI DSL Command', () => {
   it('should execute dsl command and show DSL structure', () => {
     const command = 'node dist/cli/index.js dsl';

src/cli/index.ts

@@ -14,8 +14,10 @@ import { initCommand } from '../templates/init-command.js';
 import { DSLIntrospector } from '../dsl/introspection.js';
 import { parseWorkflowFile } from '../parsing/parser.js';
 import { Command } from 'commander';
+import { execFileSync } from 'child_process';
 import * as path from 'path';
 import * as fs from 'fs';
+import * as os from 'os';
 
 // Simple error handling - no fancy logging or correlation IDs
 function handleError(error: unknown, operation: string): never {
@@ -53,6 +55,29 @@ async function writeScriptToFile(script: string, outputFile: string): Promise<vo
   }
 }
 
+/**
+ * Validate generated script for bash syntax errors.
+ */
+function validateBashSyntax(script: string): void {
+  const tempDir = fs.mkdtempSync(path.join(os.tmpdir(), 'flowsh-syntax-check-'));
+  const tempFile = path.join(tempDir, 'script.sh');
+
+  try {
+    fs.writeFileSync(tempFile, script, 'utf8');
+    execFileSync('bash', ['-n', tempFile], { stdio: 'pipe' });
+  } catch (error: any) {
+    const errorOutput = error?.stderr?.toString?.() || error?.message || 'Unknown bash error';
+    throw new Error(`Bash syntax validation failed:\n${errorOutput}`);
+  } finally {
+    try {
+      fs.unlinkSync(tempFile);
+      fs.rmdirSync(tempDir);
+    } catch {
+      // Best-effort cleanup
+    }
+  }
+}
+
 /**
  * Compile command: Convert YAML workflow to shell script
  */
@@ -123,6 +148,16 @@ async function compileCommand(
       finalScript = warnings.join('\n') + '\n' + finalScript;
     }
 
+    if (options.verbose) {
+      console.error('🔍 Validating bash syntax...');
+    }
+
+    validateBashSyntax(finalScript);
+
+    if (options.verbose) {
+      console.error('✅ Bash syntax validation passed');
+    }
+
     // Dry-run mode: validate and compile but don't output
     if (options.dryRun) {
       const nodeCount = parseResult.workflow?.graph?.nodes?.length || 0;

tests/workflows/invalid-bash-test.yaml

@@ -0,0 +1,31 @@
+workflow:
+  name: 'Invalid Bash'
+  description: 'Workflow with intentionally invalid bash to test syntax validation'
+
+graph:
+  nodes:
+    - id: 'start'
+      type: 'start'
+      data:
+        title: 'Start'
+
+    - id: 'invalid_command'
+      type: 'code'
+      data:
+        title: 'Invalid Command'
+        description: 'Command with unterminated quote'
+        command: 'echo "unterminated'
+
+    - id: 'end'
+      type: 'end'
+      data:
+        title: 'End'
+
+  edges:
+    - id: 'start_to_invalid'
+      source: 'start'
+      target: 'invalid_command'
+
+    - id: 'invalid_to_end'
+      source: 'invalid_command'
+      target: 'end'