Merge pull request #35 from tbreuss/develop

Develop

Author: tbreuss

.editorconfig

@@ -9,6 +9,6 @@ charset = utf-8
 indent_style = space
 indent_size = 4
 
-[*.{html,json,twig}]
+[*.{html,json,neon,twig}]
 indent_style = space
 indent_size = 2

.github/workflows/cicd.yml

@@ -30,6 +30,8 @@ jobs:
         run: composer install --no-progress --prefer-dist --optimize-autoloader
       - name: Test coding style
         run: bin/coding-style.sh
+      - name: Run static code analysis
+        run: bin/code-analysis.sh
       - name: Run functional tests
         run: bin/functional.sh localhost:9876
       - name: Run website tests

bin/code-analysis.sh

@@ -0,0 +1,6 @@
+#!/bin/sh
+# Run static code analysis against a Docker container
+
+set -eu
+
+docker run --rm -v .:/app ghcr.io/phpstan/phpstan analyse

phpstan.neon

@@ -0,0 +1,6 @@
+parameters:
+  level: 5
+  paths:
+    - .
+  excludePaths:
+    - **/vendor/**

tests/_data/routes/articles/[id]/comments.php

@@ -1,5 +1,7 @@
 <?php declare(strict_types=1);
 
+/** @var tebe\zack\routing\PhpRouteHandler $this */
+
 return $this->html('articles/comments.html.twig', [
     'title' => 'GET: Articles.[id].Comments.Php',
 ]);

tests/_data/routes/articles/[id]/index.php

@@ -1,5 +1,7 @@
 <?php declare(strict_types=1);
 
+/** @var tebe\zack\routing\PhpRouteHandler $this */
+
 return $this->html('articles/detail.html.twig', [
     'title' => 'GET: Articles.[id].Php',
 ]);

tests/_data/routes/articles/index.php

@@ -1,5 +1,7 @@
 <?php declare(strict_types=1);
 
+/** @var tebe\zack\routing\PhpRouteHandler $this */
+
 return $this->html('articles/list.html.twig', [
     'title' => 'GET: Articles.Php',
 ]);

tests/_data/routes/doc-examples/hello/[name].php

@@ -1,5 +1,7 @@
 <?php declare(strict_types=1);
 
+/** @var Symfony\Component\HttpFoundation\Request $request */
+
 use Symfony\Component\HttpFoundation\Response;
 
 $name = $request->attributes->get('name');

tests/_data/routes/doc-examples/hello/[name]/[age].php

@@ -1,5 +1,7 @@
 <?php declare(strict_types=1);
 
+/** @var Symfony\Component\HttpFoundation\Request $request */
+
 use Symfony\Component\HttpFoundation\Response;
 
 $name = $request->attributes->get('name');

tests/_data/routes/doc-examples/hello/catchall/[...name].php

@@ -1,7 +1,9 @@
 <?php declare(strict_types=1);
 
+/** @var Symfony\Component\HttpFoundation\Request $request */
+
 use Symfony\Component\HttpFoundation\Response;
 
 $name = $request->attributes->get('name');
 
-return new Response("Hello ${name}!", 200);
+return new Response("Hello $name!", 200);