Skip to content

Commit d4c5502

Browse files
committed
Refactor variables
1 parent 1f66418 commit d4c5502

1 file changed

Lines changed: 11 additions & 11 deletions

File tree

src/routing/PhpRouteHandler.php

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -24,19 +24,19 @@ public function __invoke(Request $request): Response
2424
}
2525

2626
ob_start();
27-
$response = require $path;
28-
$contents = ob_get_clean();
27+
$returnValue = require $path;
28+
$outputValue = ob_get_clean();
2929

30-
if ($response === 1 && is_string($contents)) {
31-
return new Response($contents, 200);
32-
} elseif (is_string($response) && is_string($contents) && strlen($contents) > 0) {
30+
if ($returnValue === 1 && is_string($outputValue)) {
31+
return new Response($outputValue, 200);
32+
} elseif (is_string($returnValue) && is_string($outputValue) && strlen($outputValue) > 0) {
3333
throw new \Exception('In the PHP file the return value must be omitted if an output was made via echo: ' . $path);
34-
} elseif (is_string($response)) {
35-
return new Response($response, 200);
36-
} elseif (is_array($response)) {
37-
return $this->json($response);
38-
} elseif ($response instanceof Response) {
39-
return $response;
34+
} elseif (is_string($returnValue)) {
35+
return new Response($returnValue, 200);
36+
} elseif (is_array($returnValue)) {
37+
return $this->json($returnValue);
38+
} elseif ($returnValue instanceof Response) {
39+
return $returnValue;
4040
} else {
4141
throw new \Exception('The PHP file must output something or return a string, an array or a response object: ' . $path);
4242
}

0 commit comments

Comments
 (0)