Commit 2d7548a
refactor(testing): replace the stringly-typed signature tamper with a typed union (leanEthereum#859)
The signed-block tamper hook was a dict of magic operation strings
dispatched through a 130-line if ladder, while the proof fixtures
already model tampers as a typed union matched with structural
patterns. Migrate the laggard to the same pattern:
- one Pydantic model per mutation, each documenting the rejection
path it exercises,
- a closed union replacing the raw dict, so a misspelled operation
or missing argument fails at construction instead of at fill time,
- structural pattern matching replacing the if ladder.
Fixture JSON is unchanged: the tamper field is excluded from output.
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>1 parent 863dd1e commit 2d7548a
6 files changed
Lines changed: 247 additions & 170 deletions
File tree
- packages/testing/src/consensus_testing
- test_fixtures
- tests/consensus/lstar/verify_signatures
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
| 9 | + | |
9 | 10 | | |
| 11 | + | |
| 12 | + | |
10 | 13 | | |
11 | 14 | | |
12 | 15 | | |
13 | 16 | | |
14 | 17 | | |
| 18 | + | |
15 | 19 | | |
16 | 20 | | |
17 | 21 | | |
| 22 | + | |
18 | 23 | | |
19 | 24 | | |
20 | 25 | | |
| 26 | + | |
21 | 27 | | |
22 | 28 | | |
23 | 29 | | |
| |||
76 | 82 | | |
77 | 83 | | |
78 | 84 | | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
79 | 91 | | |
80 | 92 | | |
81 | 93 | | |
| |||
Lines changed: 15 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
23 | | - | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
24 | 32 | | |
25 | 33 | | |
26 | 34 | | |
| |||
34 | 42 | | |
35 | 43 | | |
36 | 44 | | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
37 | 51 | | |
38 | 52 | | |
39 | 53 | | |
| |||
0 commit comments