Skip to content

Commit 0cfa38f

Browse files
committed
Expect nil current_retry_interval for paused activity
A paused activity is held on the server and not dispatched to Matching, but it reaches the same code path as a dispatched retry, so current_retry_interval is now nil for it too. Run: go test ./tests/xdc/ -run 'TestActivityApiStateReplicationSuite/TestPauseActivityFailover'
1 parent 525929e commit 0cfa38f

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

tests/xdc/activity_api_test.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -154,7 +154,7 @@ func (s *ActivityApiStateReplicationSuite) TestPauseActivityFailover() {
154154
if description.GetPendingActivities() != nil {
155155
require.Len(t, description.PendingActivities, 1)
156156
require.True(t, description.PendingActivities[0].Paused)
157-
require.Equal(t, int64(2), description.PendingActivities[0].CurrentRetryInterval.GetSeconds())
157+
require.Nil(t, description.PendingActivities[0].CurrentRetryInterval)
158158
}
159159
}, 5*time.Second, 200*time.Millisecond)
160160

@@ -180,7 +180,7 @@ func (s *ActivityApiStateReplicationSuite) TestPauseActivityFailover() {
180180
require.Len(t, description.PendingActivities, 1)
181181
require.True(t, description.PendingActivities[0].Paused)
182182
require.Equal(t, int32(1), description.PendingActivities[0].Attempt)
183-
require.Equal(t, int64(2), description.PendingActivities[0].CurrentRetryInterval.GetSeconds())
183+
require.Nil(t, description.PendingActivities[0].CurrentRetryInterval)
184184
}
185185
}, 5*time.Second, 200*time.Millisecond)
186186

@@ -206,7 +206,7 @@ func (s *ActivityApiStateReplicationSuite) TestPauseActivityFailover() {
206206
if description.GetPendingActivities() != nil {
207207
require.Len(t, description.PendingActivities, 1)
208208
require.True(t, description.PendingActivities[0].Paused)
209-
require.Equal(t, int64(2), description.PendingActivities[0].CurrentRetryInterval.GetSeconds())
209+
require.Nil(t, description.PendingActivities[0].CurrentRetryInterval)
210210
require.Equal(t, int32(10), description.PendingActivities[0].MaximumAttempts)
211211
}
212212
}, 5*time.Second, 200*time.Millisecond)

0 commit comments

Comments
 (0)