Skip to content

Commit 90753fd

Browse files
[serve] Fix deploy check (flagos-ai#1116)
### PR Category Serve ### PR Types Bug Fixes ### PR Description Fix deploy check.
1 parent 09a6e24 commit 90753fd

2 files changed

Lines changed: 5 additions & 1 deletion

File tree

flagscale/runner/launcher/launcher_ssh.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -104,6 +104,8 @@ def _get_runner_cmd_train(
104104
del runner_args["enable_monitoring"]
105105
if "enable_gpu_health_check" in runner_args:
106106
del runner_args["enable_gpu_health_check"]
107+
if "deploy" in runner_args:
108+
del runner_args["deploy"]
107109
runner_args["rdzv_id"] = rdzv_id
108110
# runner_args["master_addr"] = master_addr
109111
# runner_args["master_port"] = master_port

flagscale/runner/runner_base.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,9 +47,11 @@ def __init__(self, config: DictConfig):
4747
# normalize native → native_{task_type}
4848
if backend_type == "native":
4949
backend_type = f"native_{self.task_type}"
50+
51+
if backend_type == "native_serve":
5052
if self.config.experiment.runner.get(
5153
"deploy", None
52-
) is None or self.config.experiment.runner.deploy.get("use_fs_serve", False):
54+
) is None or not self.config.experiment.runner.deploy.get("use_fs_serve", False):
5355
raise ValueError("config.experiment.deploy.use_fs_serve in YAML should be true")
5456

5557
self.backend_type = backend_type

0 commit comments

Comments
 (0)