Skip to content

feat: Add support for access tags to App Config module#370

Merged
vbontempi merged 9 commits into
mainfrom
17232-desc-tag
Apr 22, 2026
Merged

feat: Add support for access tags to App Config module#370
vbontempi merged 9 commits into
mainfrom
17232-desc-tag

Conversation

@iamar7

@iamar7 iamar7 commented Apr 14, 2026

Copy link
Copy Markdown
Member

Description

This PR add supports of access_tags in the App Configuration module and it updates the following

  • tags -> resource_tags
  • resource_tags variable description and validation

Resolves: #371

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

This release adds support for access_tags in the module and renames the app_config_tags variable to resource_tags. It also enhances the resource_tags variable description and validation.

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@iamar7

iamar7 commented Apr 16, 2026

Copy link
Copy Markdown
Member Author

/run pipeline

@iamar7

iamar7 commented Apr 17, 2026

Copy link
Copy Markdown
Member Author

/run pipeline

@iamar7 iamar7 changed the title fix: standardize resource_tags variable, update descriptions and add access tag validation feat: Add support for access tags to App Config module Apr 17, 2026
@iamar7 iamar7 self-assigned this Apr 17, 2026
@iamar7
iamar7 marked this pull request as ready for review April 17, 2026 09:33
@iamar7
iamar7 requested a review from mukulpalit-ibm as a code owner April 17, 2026 09:33
@iamar7

iamar7 commented Apr 20, 2026

Copy link
Copy Markdown
Member Author

/run pipeline

@iamar7

iamar7 commented Apr 20, 2026

Copy link
Copy Markdown
Member Author

Re-running

[TestAddonsDefaultConfiguration] Errors occurred during infrastructure deployment
[TestAddonsDefaultConfiguration] Note: IBM Cloud Projects workflow requires successful validation (terraform plan) before deployment (terraform apply)
[TestAddonsDefaultConfiguration] If validation failed, infrastructure was never deployed - only configurations were added to project
[TestAddonsDefaultConfiguration]   Schematics job logs for member: deploy-arch-ibm-event-notifications-mevfdc, Schematics Workspace CRN: crn:v1:bluemix:public:schematics:us-south:a/abac0df06b644a9cabc6e44f55b3880e:678a3495-26a0-49cd-b858-2305016e1400:workspace:us-south.workspace.projects-service.0fa7d4b0, Schematics Deploy Job ID: ddb4e81e0dd7eb6692c1b530605126f7
Schematics workspace URL: https://cloud.ibm.com/schematics/workspaces/us-south.workspace.projects-service.0fa7d4b0/jobs?region=us
Schematics Job URL: https://cloud.ibm.com/schematics/workspaces/us-south.workspace.projects-service.0fa7d4b0/log/ddb4e81e0dd7eb6692c1b530605126f7
	(deploy-arch-ibm-event-notifications-mevfdc) Deployment result: failed
	(deploy-arch-ibm-event-notifications-mevfdc) failed Deployment, no failed resources returned
	(deploy-arch-ibm-event-notifications-mevfdc) failed Deployment, no failed plan messages returned
[TestAddonsDefaultConfiguration] === END BUFFERED LOG OUTPUT ===
[TestAddonsDefaultConfiguration] 🔄 Cleaning up infrastructure
[TestAddonsDefaultConfiguration] TEST EXECUTION END: TestAddonsDefaultConfiguration - RESULT: FAILED_AT_DEPLOY (error: Errors occurred during infrastructure deployment)

@iamar7

iamar7 commented Apr 20, 2026

Copy link
Copy Markdown
Member Author

/run pipeline

@mukulpalit-ibm mukulpalit-ibm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mukulpalit-ibm mukulpalit-ibm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the release notes and describe this changes

@vbontempi
vbontempi merged commit 300a233 into main Apr 22, 2026
2 checks passed
@vbontempi
vbontempi deleted the 17232-desc-tag branch April 22, 2026 09:08
@terraform-ibm-modules-ops

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 1.18.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[terraform-ibm-app-configuration] Add support for access management tags in App Configuration instance

4 participants