Skip to content

Commit fc18439

Browse files
committed
ci: test for == 'false' instead of != 'true' to ensure unexpected values are not evaluating to true
1 parent 5b6ea4b commit fc18439

5 files changed

Lines changed: 14 additions & 14 deletions

File tree

.github/workflows/buildx.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ jobs:
2626

2727
teslamate_build:
2828
needs: check_paths
29-
if: needs.check_paths.outputs.githubfolder != 'true' || github.event_name == 'schedule'
29+
if: needs.check_paths.outputs.githubfolder == 'false' || github.event_name == 'schedule'
3030
strategy:
3131
fail-fast: false
3232
matrix:
@@ -62,7 +62,7 @@ jobs:
6262
needs:
6363
- check_paths
6464
- teslamate_build
65-
if: needs.check_paths.outputs.githubfolder != 'true' || github.event_name == 'schedule'
65+
if: needs.check_paths.outputs.githubfolder == 'false' || github.event_name == 'schedule'
6666
steps:
6767
- name: Checkout
6868
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
@@ -83,7 +83,7 @@ jobs:
8383
type=edge
8484
grafana:
8585
needs: check_paths
86-
if: needs.check_paths.outputs.githubfolder != 'true' || github.event_name == 'schedule'
86+
if: needs.check_paths.outputs.githubfolder == 'false' || github.event_name == 'schedule'
8787
runs-on: ubuntu-24.04
8888
timeout-minutes: 10
8989
steps:

.github/workflows/cleanup_caches.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ jobs:
2222
cleanup:
2323
name: Delete caches when PR is closed
2424
needs: check_paths
25-
if: needs.check_paths.outputs.githubfolder != 'true'
25+
if: needs.check_paths.outputs.githubfolder == 'false'
2626
runs-on: ubuntu-24.04
2727

2828
steps:

.github/workflows/devops.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -32,26 +32,26 @@ jobs:
3232

3333
spell_check:
3434
needs: check_paths
35-
if: needs.check_paths.outputs.githubfolder != 'true' || github.event_name == 'schedule'
35+
if: needs.check_paths.outputs.githubfolder == 'false' || github.event_name == 'schedule'
3636
uses: ./.github/workflows/spell_check.yml
3737

3838
ensure_linting:
3939
needs:
4040
- check_paths
4141
- spell_check
42-
if: needs.check_paths.outputs.githubfolder != 'true' || github.event_name == 'schedule'
42+
if: needs.check_paths.outputs.githubfolder == 'false' || github.event_name == 'schedule'
4343
uses: ./.github/workflows/ensure_linting.yml
4444

4545
elixir_dep_verification_and_static_analysis:
4646
needs:
4747
- check_paths
4848
- ensure_linting
49-
if: needs.check_paths.outputs.githubfolder != 'true' || github.event_name == 'schedule'
49+
if: needs.check_paths.outputs.githubfolder == 'false' || github.event_name == 'schedule'
5050
uses: ./.github/workflows/elixir_dep_verification_and_static_analysis.yml
5151

5252
elixir_test:
5353
needs:
5454
- check_paths
5555
- ensure_linting
56-
if: needs.check_paths.outputs.githubfolder != 'true' || github.event_name == 'schedule'
56+
if: needs.check_paths.outputs.githubfolder == 'false' || github.event_name == 'schedule'
5757
uses: ./.github/workflows/elixir_test.yml

.github/workflows/ghcr_build.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,15 +29,15 @@ jobs:
2929

3030
check_if_pr_from_outside_repo:
3131
needs: check_paths
32-
if: needs.check_paths.outputs.githubfolder != 'true'
32+
if: needs.check_paths.outputs.githubfolder == 'false'
3333
uses: ./.github/workflows/check_if_pr_from_outside_repo.yml
3434

3535
teslamate_build:
3636
name: Build images
3737
needs:
3838
- check_paths
3939
- check_if_pr_from_outside_repo
40-
if: needs.check_paths.outputs.githubfolder != 'true' && needs.check_if_pr_from_outside_repo.outputs.is_pr_from_outside_repo == 'false'
40+
if: needs.check_paths.outputs.githubfolder == 'false' && needs.check_if_pr_from_outside_repo.outputs.is_pr_from_outside_repo == 'false'
4141
strategy:
4242
fail-fast: false
4343
matrix:
@@ -73,7 +73,7 @@ jobs:
7373
needs:
7474
- check_paths
7575
- teslamate_build
76-
if: needs.check_paths.outputs.githubfolder != 'true'
76+
if: needs.check_paths.outputs.githubfolder == 'false'
7777
runs-on: ubuntu-24.04
7878
timeout-minutes: 10
7979
steps:
@@ -95,7 +95,7 @@ jobs:
9595
needs:
9696
- check_paths
9797
- check_if_pr_from_outside_repo
98-
if: needs.check_paths.outputs.githubfolder != 'true' && needs.check_if_pr_from_outside_repo.outputs.is_pr_from_outside_repo == 'false'
98+
if: needs.check_paths.outputs.githubfolder == 'false' && needs.check_if_pr_from_outside_repo.outputs.is_pr_from_outside_repo == 'false'
9999
runs-on: ubuntu-24.04
100100
steps:
101101
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2

.github/workflows/ghcr_purge.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,15 +21,15 @@ jobs:
2121

2222
check_if_pr_from_outside_repo:
2323
needs: check_paths
24-
if: needs.check_paths.outputs.githubfolder != 'true'
24+
if: needs.check_paths.outputs.githubfolder == 'false'
2525
uses: ./.github/workflows/check_if_pr_from_outside_repo.yml
2626

2727
purge-pr-package:
2828
name: Delete images from ghcr.io when PR is closed
2929
needs:
3030
- check_paths
3131
- check_if_pr_from_outside_repo
32-
if: needs.check_paths.outputs.githubfolder != 'true' && needs.check_if_pr_from_outside_repo.outputs.is_pr_from_outside_repo == 'false'
32+
if: needs.check_paths.outputs.githubfolder == 'false' && needs.check_if_pr_from_outside_repo.outputs.is_pr_from_outside_repo == 'false'
3333
runs-on: ubuntu-24.04
3434
concurrency:
3535
group: "purge-pr-images"

0 commit comments

Comments
 (0)