Skip to content

Commit 09ca0d6

Browse files
authored
Merge pull request #783 from the-virtual-brain/TVB-3144
TVB-3144. Fix parsing of parameters for PSE
2 parents 5467cb1 + 84dcf38 commit 09ca0d6

3 files changed

Lines changed: 12 additions & 10 deletions

File tree

tvb_framework/tvb/adapters/forms/form_with_ranges.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ def get_range_parameters(self, prefix):
5757

5858
result = []
5959
for range_param in parameters_for_pse:
60-
range_obj = RangeParameter(range_param.label, float, range_param.domain,
60+
range_obj = RangeParameter(range_param.field_name, float, range_param.domain,
6161
isinstance(range_param, NArray))
6262
self.ensure_correct_prefix_for_param_name(range_obj, prefix)
6363
result.append(range_obj)

tvb_framework/tvb/core/services/backend_clients/standalone_client.py

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -61,9 +61,11 @@ def get_host_current_host_ip():
6161
"""
6262
:return: current host ip address
6363
"""
64-
hostname = socket.gethostname()
65-
ip_addr = socket.gethostbyname(hostname)
66-
return ip_addr
64+
try:
65+
hostname = socket.gethostname()
66+
return socket.gethostbyname(hostname)
67+
except socket.gaierror:
68+
return "127.0.0.1"
6769

6870

6971
class OperationExecutor(Thread):

tvb_framework/tvb/tests/framework/interfaces/web/controllers/simulator_controller_test.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -891,8 +891,8 @@ def test_setup_pse(self):
891891
assert self.session_stored_simulator.simulation_length == 1000, "Incorrect simulation length!"
892892

893893
def test_set_pse_params(self):
894-
self.sess_mock['pse_param1'] = "model.:math:`a`"
895-
self.sess_mock['pse_param2'] = "model.:math:`c`"
894+
self.sess_mock['pse_param1'] = "model.a"
895+
self.sess_mock['pse_param2'] = "model.c"
896896

897897
self.simulator_controller.range_parameters.coupling_parameters = get_form_for_coupling(type(
898898
self.session_stored_simulator.coupling))().get_range_parameters(Simulator.coupling.field_name)
@@ -911,17 +911,17 @@ def test_set_pse_params(self):
911911
self.simulator_controller.context.set_simulator(self.session_stored_simulator)
912912
rendering_rules = self.simulator_controller.set_pse_params(**self.sess_mock._data)
913913

914-
assert eval(burst_config.range1)[0] == 'model.:math:`a`', "pse_param1 was not set correctly!"
915-
assert eval(burst_config.range2)[0] == 'model.:math:`c`', "pse_param2 was not set correctly!"
914+
assert eval(burst_config.range1)[0] == 'model.a', "pse_param1 was not set correctly!"
915+
assert eval(burst_config.range2)[0] == 'model.c', "pse_param2 was not set correctly!"
916916
assert rendering_rules['renderer'].include_launch_pse_button, 'Launch PSE button should be displayed!'
917917
assert not rendering_rules['renderer'].include_next_button, 'Next button should not be displayed!'
918918

919919
def test_launch_pse(self):
920-
self.sess_mock['pse_param1_name'] = 'model.:math:`a`'
920+
self.sess_mock['pse_param1_name'] = 'model.a'
921921
self.sess_mock['pse_param1_lo'] = '-5.0'
922922
self.sess_mock['pse_param1_hi'] = '5.0'
923923
self.sess_mock['pse_param1_step'] = '5.0'
924-
self.sess_mock['pse_param2_name'] = 'model.:math:`c`'
924+
self.sess_mock['pse_param2_name'] = 'model.c'
925925
self.sess_mock['pse_param2_lo'] = '-10.0'
926926
self.sess_mock['pse_param2_hi'] = '10.0'
927927
self.sess_mock['pse_param2_step'] = '10.0'

0 commit comments

Comments
 (0)