perf(scroll): reject dropped events earlier

avoid extra hot-path work for scroll events that will pass through

- move continuous, phased, diagonal, and zero-delta checks before flag reads and terminal state lookup
- update hot-path profiling option parsing and current precision api call

Author: theBucky

probo/Sources/Events/ScrollEventRewriter.swift

@@ -15,6 +15,26 @@ struct ScrollEventRewriter {
       return false
     }
 
+    let isContinuous = event.getIntegerValueField(.scrollWheelEventIsContinuous) != 0
+    if isContinuous {
+      return false
+    }
+
+    let hasPhase =
+      event.getIntegerValueField(.scrollWheelEventScrollPhase) != 0
+      || event.getIntegerValueField(.scrollWheelEventMomentumPhase) != 0
+    if hasPhase {
+      return false
+    }
+
+    let deltaAxis1 = Int32(
+      truncatingIfNeeded: event.getIntegerValueField(.scrollWheelEventDeltaAxis1))
+    let deltaAxis2 = Int32(
+      truncatingIfNeeded: event.getIntegerValueField(.scrollWheelEventDeltaAxis2))
+    if (deltaAxis1 != 0) == (deltaAxis2 != 0) {
+      return false
+    }
+
     let originalFlags = event.flags
     let decision = ScrollRewriteCore.decidePrecision(
       isOptionHeld: originalFlags.contains(.maskAlternate),
@@ -23,14 +43,11 @@ struct ScrollEventRewriter {
         configuration.isTerminalOptimizationEnabled && isTerminalFrontmost(),
     )
     let input = ScrollRewriteInput(
-      deltaAxis1: Int32(
-        truncatingIfNeeded: event.getIntegerValueField(.scrollWheelEventDeltaAxis1)),
-      deltaAxis2: Int32(
-        truncatingIfNeeded: event.getIntegerValueField(.scrollWheelEventDeltaAxis2)),
+      deltaAxis1: deltaAxis1,
+      deltaAxis2: deltaAxis2,
       intensity: configuration.intensity,
-      isContinuous: event.getIntegerValueField(.scrollWheelEventIsContinuous) != 0,
-      hasPhase: event.getIntegerValueField(.scrollWheelEventScrollPhase) != 0
-        || event.getIntegerValueField(.scrollWheelEventMomentumPhase) != 0,
+      isContinuous: isContinuous,
+      hasPhase: hasPhase,
       isPrecision: decision.isPrecision,
       isTrackpadStyleScrollingEnabled: configuration.isTrackpadStyleScrollingEnabled
     )

probo/Tools/HotPathProfile/HotPathProfile.swift

@@ -170,10 +170,9 @@ struct HotPathProfile {
 
 private func parseOptions() throws -> Options {
   var options = Options()
-  var arguments = Array(CommandLine.arguments.dropFirst())
+  var arguments = CommandLine.arguments.dropFirst()
 
-  while !arguments.isEmpty {
-    let argument = arguments.removeFirst()
+  while let argument = arguments.popFirst() {
     switch argument {
     case "--iterations":
       options.iterations = try takePositiveInt(&arguments, argument)
@@ -203,19 +202,19 @@ private func parseOptions() throws -> Options {
   return options
 }
 
-private func takePositiveInt(_ arguments: inout [String], _ name: String) throws -> Int {
+private func takePositiveInt(_ arguments: inout ArraySlice<String>, _ name: String) throws -> Int {
   let value = try takeNonNegativeInt(&arguments, name)
   if value <= 0 {
     throw ProbeError.message("\(name) must be positive")
   }
   return value
 }
 
-private func takeNonNegativeInt(_ arguments: inout [String], _ name: String) throws -> Int {
-  guard let rawValue = arguments.first else {
+private func takeNonNegativeInt(_ arguments: inout ArraySlice<String>, _ name: String) throws -> Int
+{
+  guard let rawValue = arguments.popFirst() else {
     throw ProbeError.message("missing value for \(name)")
   }
-  arguments.removeFirst()
   guard let value = Int(rawValue), value >= 0 else {
     throw ProbeError.message("\(name) must be a non-negative integer")
   }
@@ -249,8 +248,7 @@ private func makeRewriteInput(event: CGEvent, configuration: AppConfiguration) -
   let decision = ScrollRewriteCore.decidePrecision(
     isOptionHeld: originalFlags.contains(.maskAlternate),
     isOptionPrecisionEnabled: configuration.isOptionPrecisionEnabled,
-    isTerminalFrontmost: false,
-    isTerminalDefaultPrecisionEnabled: configuration.isTerminalDefaultPrecisionEnabled
+    isTerminalOptimizationActive: false
   )
 
   return ScrollRewriteInput(