Fixed issue that prevented service providers from registering if a previous one in the aggregate was already registered.

philipobenito · philipobenito · commit fa38155fa392 · 2018-09-28T14:24:15.000+01:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,11 @@
 
 All Notable changes to `League\Container` will be documented in this file
 
+## 3.2.2
+
+### Fixed
+- Fixed issue that prevented service providers from registering if a previous one in the aggregate was already registered.
+
 ## 3.2.1
 
 ### Fixed
diff --git a/src/ServiceProvider/ServiceProviderAggregate.php b/src/ServiceProvider/ServiceProviderAggregate.php
@@ -90,7 +90,7 @@ public function register(string $service)
 
         foreach ($this->getIterator() as $provider) {
             if (in_array($provider->getIdentifier(), $this->registered)) {
-                return;
+                continue;
             }
 
             if ($provider->provides($service)) {

Original file line number	Diff line number	Diff line change
`@@ -90,7 +90,7 @@ public function register(string $service)`
`90`	`90`
`91`	`91`	`foreach ($this->getIterator() as $provider) {`
`92`	`92`	`if (in_array($provider->getIdentifier(), $this->registered)) {`
`93`		`- return;`
	`93`	`+ continue;`
`94`	`94`	`}`
`95`	`95`
`96`	`96`	`if ($provider->provides($service)) {`