Old phpstan/phpstan seemingly being installed on "Static Analysis (8.5, prefer-lowest, ubuntu-latest)" job creates a lot of deprecated logspam

[reedy]

Seen while playing with wikimedia#19

https://github.com/wikimedia/oauth2-server/actions/runs/20623941951/job/59231098679?pr=19

  - Locking phpstan/extension-installer (1.3.1)
  - Locking phpstan/phpdoc-parser (1.23.1)
  - Locking phpstan/phpstan (1.12.0)
  - Locking phpstan/phpstan-deprecation-rules (1.1.4)
  - Locking phpstan/phpstan-phpunit (1.3.15)
  - Locking phpstan/phpstan-strict-rules (1.5.2)

Which results in a lot of logspam:

PHP Deprecated:  Non-canonical cast (double) is deprecated, use the (float) cast instead in phar:///home/runner/work/oauth2-server/oauth2-server/vendor/phpstan/phpstan/phpstan.phar/vendor/nikic/php-parser/lib/PhpParser/PrettyPrinter/Standard.php on line 202
Deprecated: Non-canonical cast (double) is deprecated, use the (float) cast instead in phar:///home/runner/work/oauth2-server/oauth2-server/vendor/phpstan/phpstan/phpstan.phar/vendor/nikic/php-parser/lib/PhpParser/PrettyPrinter/Standard.php on line 202
Note: Using configuration file /home/runner/work/oauth2-server/oauth2-server/phpstan.neon.dist.
PHP Deprecated:  Using null as the key parameter for array_key_exists() is deprecated, use an empty string instead in phar:///home/runner/work/oauth2-server/oauth2-server/vendor/phpstan/phpstan/phpstan.phar/vendor/hoa/compiler/Llk/Parser.php on line 146
Deprecated: Using null as the key parameter for array_key_exists() is deprecated, use an empty string instead in phar:///home/runner/work/oauth2-server/oauth2-server/vendor/phpstan/phpstan/phpstan.phar/vendor/hoa/compiler/Llk/Parser.php on line 146
PHP Deprecated:  Method SplObjectStorage::contains() is deprecated since 8.5, use method SplObjectStorage::offsetExists() instead in phar:///home/runner/work/oauth2-server/oauth2-server/vendor/phpstan/phpstan/phpstan.phar/vendor/nette/di/src/DI/Resolver.php on line 49
Deprecated: Method SplObjectStorage::contains() is deprecated since 8.5, use method SplObjectStorage::offsetExists() instead in phar:///home/runner/work/oauth2-server/oauth2-server/vendor/phpstan/phpstan/phpstan.phar/vendor/nette/di/src/DI/Resolver.php on line 49
PHP Deprecated:  Method SplObjectStorage::attach() is deprecated since 8.5, use method SplObjectStorage::offsetSet() instead in phar:///home/runner/work/oauth2-server/oauth2-server/vendor/phpstan/phpstan/phpstan.phar/vendor/nette/di/src/DI/Resolver.php on line 56
Deprecated: Method SplObjectStorage::attach() is deprecated since 8.5, use method SplObjectStorage::offsetSet() instead in phar:///home/runner/work/oauth2-server/oauth2-server/vendor/phpstan/phpstan/phpstan.phar/vendor/nette/di/src/DI/Resolver.php on line 56
PHP Deprecated:  Method SplObjectStorage::detach() is deprecated since 8.5, use method SplObjectStorage::offsetUnset() instead in phar:///home/runner/work/oauth2-server/oauth2-server/vendor/phpstan/phpstan/phpstan.phar/vendor/nette/di/src/DI/Resolver.php on line 64
Deprecated: Method SplObjectStorage::detach() is deprecated since 8.5, use method SplObjectStorage::offsetUnset() instead in phar:///home/runner/work/oauth2-server/oauth2-server/vendor/phpstan/phpstan/phpstan.phar/vendor/nette/di/src/DI/Resolver.php on line 64
PHP Deprecated:  Method SplObjectStorage::contains() is deprecated since 8.5, use method SplObjectStorage::offsetExists() instead in phar:///home/runner/work/oauth2-server/oauth2-server/vendor/phpstan/phpstan/phpstan.phar/vendor/nette/di/src/DI/Resolver.php on line 49
Deprecated: Method SplObjectStorage::contains() is deprecated since 8.5, use method SplObjectStorage::offsetExists() instead in phar:///home/runner/work/oauth2-server/oauth2-server/vendor/phpstan/phpstan/phpstan.phar/vendor/nette/di/src/DI/Resolver.php on line 49
PHP Deprecated:  Method SplObjectStorage::attach() is deprecated since 8.5, use method SplObjectStorage::offsetSet() instead in phar:///home/runner/work/oauth2-server/oauth2-server/vendor/phpstan/phpstan/phpstan.phar/vendor/nette/di/src/DI/Resolver.php on line 56
Deprecated: Method SplObjectStorage::attach() is deprecated since 8.5, use method SplObjectStorage::offsetSet() instead in phar:///home/runner/work/oauth2-server/oauth2-server/vendor/phpstan/phpstan/phpstan.phar/vendor/nette/di/src/DI/Resolver.php on line 56
PHP Deprecated:  Method SplObjectStorage::detach() is deprecated since 8.5, use method SplObjectStorage::offsetUnset() instead in phar:///home/runner/work/oauth2-server/oauth2-server/vendor/phpstan/phpstan/phpstan.phar/vendor/nette/di/src/DI/Resolver.php on line 64
Deprecated: Method SplObjectStorage::detach() is deprecated since 8.5, use method SplObjectStorage::offsetUnset() instead in phar:///home/runner/work/oauth2-server/oauth2-server/vendor/phpstan/phpstan/phpstan.phar/vendor/nette/di/src/DI/Resolver.php on line 64
PHP Deprecated:  Method SplObjectStorage::contains() is deprecated since 8.5, use method SplObjectStorage::offsetExists() instead in phar:///home/runner/work/oauth2-server/oauth2-server/vendor/phpstan/phpstan/phpstan.phar/vendor/nette/di/src/DI/Resolver.php on line 49
Deprecated: Method SplObjectStorage::contains() is deprecated since 8.5, use method SplObjectStorage::offsetExists() instead in phar:///home/runner/work/oauth2-server/oauth2-server/vendor/phpstan/phpstan/phpstan.phar/vendor/nette/di/src/DI/Resolver.php on line 49
PHP Deprecated:  Method SplObjectStorage::attach() is deprecated since 8.5, use method SplObjectStorage::offsetSet() instead in phar:///home/runner/work/oauth2-server/oauth2-server/vendor/phpstan/phpstan/phpstan.phar/vendor/nette/di/src/DI/Resolver.php on line 56
Deprecated: Method SplObjectStorage::attach() is deprecated since 8.5, use method SplObjectStorage::offsetSet() instead in phar:///home/runner/work/oauth2-server/oauth2-server/vendor/phpstan/phpstan/phpstan.phar/vendor/nette/di/src/DI/Resolver.php on line 56
PHP Deprecated:  Method SplObjectStorage::detach() is deprecated since 8.5, use method SplObjectStorage::offsetUnset() instead in phar:///home/runner/work/oauth2-server/oauth2-server/vendor/phpstan/phpstan/phpstan.phar/vendor/nette/di/src/DI/Resolver.php on line 64
Deprecated: Method SplObjectStorage::detach() is deprecated since 8.5, use method SplObjectStorage::offsetUnset() instead in phar:///home/runner/work/oauth2-server/oauth2-server/vendor/phpstan/phpstan/phpstan.phar/vendor/nette/di/src/DI/Resolver.php on line 64
PHP Deprecated:  Method SplObjectStorage::contains() is deprecated since 8.5, use method SplObjectStorage::offsetExists() instead in phar:///home/runner/work/oauth2-server/oauth2-server/vendor/phpstan/phpstan/phpstan.phar/vendor/nette/di/src/DI/Resolver.php on line 49
Deprecated: Method SplObjectStorage::contains() is deprecated since 8.5, use method SplObjectStorage::offsetExists() instead in phar:///home/runner/work/oauth2-server/oauth2-server/vendor/phpstan/phpstan/phpstan.phar/vendor/nette/di/src/DI/Resolver.php on line 49
PHP Deprecated:  Method SplObjectStorage::attach() is deprecated since 8.5, use method SplObjectStorage::offsetSet() instead in phar:///home/runner/work/oauth2-server/oauth2-server/vendor/phpstan/phpstan/phpstan.phar/vendor/nette/di/src/DI/Resolver.php on line 56

The snipped above is obviously trimmed, as a lot more deprecated warnings appear

[Sephster]

I'm not sure why this is happening for you sorry @reedy - I ran PHPStan locally on the latest build and didn't encounter any errors. Our CI build ran today without issue as well.

Looking at the errors it seems to be referencing a lot of code in the /vendor dir but PHPStan shouldn't run there. Your phpstan neon file is specifying the paths should just be src and tests so I'm not clear why it is looking at these files. I think this issue might be local to your repo though and is not affecting this one. Will be happy to reopen this if this isn't the case though. Thanks for flagging and I hope you get to the bottom of it. Happy new year when it comes

[reedy]

You can see it in your own tests too, from the CI of PR #1493

It's just buried as noise, not a test failure (whether PHP Deprecated should trigger test failures is another issue):

https://github.com/thephpleague/oauth2-server/actions/runs/20623140635/job/59228899079

[Sephster]

oh thanks. Sorry, had not seen that. Looks like there might be a configuration issue. Will check it out. Cheers!

[reedy]

https://packagist.org/packages/phpstan/phpstan#1.12.32 declares php: ^7.2|^8.0 which probably isn't wrong...

The error seems to be in vendored vendored files, for added complexity. So not even their own fault directly... But the complexity of when and where they bundle those in...

I think it's really an upstream task for them, let me file and see what they say...

[Sephster]

yeah I realise now I'm on Nixos which hasn't released 8.5 yet so I'm just not seeing this locally but I'm guessing if I was on 8.5, these deprecation notices would be firing. I don't think they should be failures as it is vendor code and only depredations at this stage. An interesting one though. Good spot

[reedy]

It's just the eternal annoyance of "why is this failing" and having to scoollllll a loooong way, especially when it fails first and the rest stop executing :)

I've filed the upstream issue, so hopefully that will get picked up.... And you should just automatically pick up the fixes as/when they make them!

[reedy]

Looks like it might be on yourselves to solve here - phpstan/phpstan#13942 (comment)

PHP 8.5 is only supported on PHPStan 2.x. Please check out the upgrade guide and upgrade.

Not helped when the version constraint happily allow PHP 8.5...

Special case in https://github.com/thephpleague/oauth2-server/blob/master/.github/workflows/static-analysis.yml for PHP 8.5 (and newer!)?

Or do you need to really support old phpstan? Let me PR removing those old versions and see what happens...