Skip to content

Commit 414195f

Browse files
committed
refactor(sources): drop the page-size argument BuildPageResult no longer uses
1 parent f6a820c commit 414195f

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

src/Sources/NeoReports.Sources.Http/HttpBatchSource.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ public async Task<BatchResult<T>> ReadBatchAsync(BatchContext context, Cancellat
9797
{
9898
HttpPaginationStrategy.LinkHeader => BuildLinkHeaderResult(records, response, requestUri),
9999
HttpPaginationStrategy.Cursor => BuildCursorResult(records, document.RootElement, state),
100-
HttpPaginationStrategy.Page => BuildPageResult(records, state, context.PageSize),
100+
HttpPaginationStrategy.Page => BuildPageResult(records, state),
101101
HttpPaginationStrategy.Offset => BuildOffsetResult(records, state),
102102
_ => throw new InvalidOperationException($"Unsupported pagination strategy '{_options.PaginationStrategy}'."),
103103
};
@@ -278,7 +278,7 @@ private BatchResult<T> BuildCursorResult(List<T> records, JsonElement responseRo
278278
// an over-max limit. The short first page then reads as the last one and the run reports
279279
// Completed with a fraction of the data. Paging until a page comes back EMPTY costs one extra
280280
// request at the end of a run and cannot truncate (ADR D72).
281-
private BatchResult<T> BuildPageResult(List<T> records, HttpCursorState state, int pageSize)
281+
private BatchResult<T> BuildPageResult(List<T> records, HttpCursorState state)
282282
{
283283
int currentPage = state.Page ?? _options.StartPage;
284284
bool hasMore = records.Count > 0;

0 commit comments

Comments
 (0)