style(core): clear Sonar smells on the A2/sample new code

- Provide DateTimeKind in the sample's seed data (S6562).
- Reword the sample header comment so it is not flagged as commented-out code (S125).
- Use explicit types where the type is not apparent, per the repo .editorconfig
  (csharp_style_var_elsewhere = false) — clears the IDE0008 suggestions on new code.
- Use the concrete JsonReportConfigParser for the test field (CA1859).

No behavior change; 33 green Core tests, sample still runs.

Author: thiagoluga

samples/04-dynamic-config-csv/InMemorySalesSourceProvider.cs

@@ -29,7 +29,7 @@ public IBatchSource<ReportRecord> Create(SourceConfig source, ReportSchema schem
                 (long)i,
                 $"Customer {i}",
                 i * 100.5m,
-                new DateTime(2026, 1, 1).AddDays(i - 1),
+                new DateTime(2026, 1, 1, 0, 0, 0, DateTimeKind.Utc).AddDays(i - 1),
             }));
         }
 

samples/04-dynamic-config-csv/Program.cs

@@ -9,17 +9,17 @@
 
 // Sample 04 — config-driven report (the dynamic path).
 //
-// The whole report is defined in report.json: there is NO typed POCO. Rows flow through the same
-// pipeline as the typed path as positional ReportRecords. What the JSON fully drives today: the
-// report name, the source selection (by id), the columns/schema (name, type, header, format,
-// culture), and the selection of outputs/destinations (by id).
+// The whole report is defined in report.json, with no typed POCO. Rows flow through the same
+// pipeline as the typed path, as positional ReportRecords. The JSON fully drives the report name,
+// the source selection by id, the columns and schema (name, type, header, format and culture) and
+// the selection of outputs and destinations by id.
 //
-// Standing in for things not built yet:
-//   - the SQL config source arrives in A3, so an in-memory IConfigSourceProvider provides the rows;
-//   - binding format/destination *options* from config arrives later (A5), so the CSV and Local
-//     factories are pre-wired in DI (the JSON's output/destination "properties" are illustrative).
+// Two pieces are still standing in. The SQL config source arrives in A3, so for now an in-memory
+// source provider supplies the rows. Binding format and destination options from config arrives
+// later in A5, so the CSV and Local factories are pre-wired in DI and the JSON properties under
+// outputs and destinations are illustrative.
 //
-//   dotnet run --project samples/04-dynamic-config-csv
+// Run with: dotnet run --project samples/04-dynamic-config-csv
 
 var configPath = Path.Combine(AppContext.BaseDirectory, "report.json");
 var json = await File.ReadAllTextAsync(configPath);

src/NeoReports.Core/Configuration/JsonReportConfigParser.cs

@@ -81,7 +81,7 @@ public override void Write(Utf8JsonWriter writer, object? value, JsonSerializerO
             // Recover round-tripped ISO-8601 timestamps as DateTime so date parameters bind
             // correctly downstream. RoundtripKind honors any 'Z'/offset and must not be combined
             // with AdjustToUniversal/AssumeUniversal (.NET rejects that pairing).
-            if (DateTime.TryParse(text, CultureInfo.InvariantCulture, DateTimeStyles.RoundtripKind, out var dt))
+            if (DateTime.TryParse(text, CultureInfo.InvariantCulture, DateTimeStyles.RoundtripKind, out DateTime dt))
                 return dt;
 
             return text;

src/NeoReports.Core/Configuration/ReportConfigCompiler.cs

@@ -41,58 +41,58 @@ public static CompiledReport Compile(ReportConfig config, IServiceProvider servi
         var columns = new ColumnDefinition<ReportRecord>[config.Columns.Count];
         for (var i = 0; i < config.Columns.Count; i++)
         {
-            var c = config.Columns[i];
+            ColumnConfig c = config.Columns[i];
             columns[i] = ReportColumns.Positional(i, c.Name, c.Type, c.Nullable, c.DisplayName, c.Format, c.Culture);
         }
 
         var schema = new ReportSchema(columns.Select(c => c.Column).ToList());
 
         // Resolve every registration up front (fail fast on a missing provider/factory) before
         // instantiating the source, which may open connections.
-        var sourceProvider = ResolveSource(services, config.Source.Type);
-        var outputs = config.Outputs
+        IConfigSourceProvider sourceProvider = ResolveSource(services, config.Source.Type);
+        OutputSpec[] outputs = config.Outputs
             .Select(o => new OutputSpec(ResolveWriter(services, o.Format), o.Properties))
             .ToArray();
-        var destinations = config.Destinations?
+        DestinationSpec[] destinations = config.Destinations?
             .Select(d => new DestinationSpec(ResolveDestination(services, d.Type), d.Properties))
             .ToArray() ?? Array.Empty<DestinationSpec>();
 
-        var source = sourceProvider.Create(config.Source, schema, services);
+        IBatchSource<ReportRecord> source = sourceProvider.Create(config.Source, schema, services);
 
-        var builder = new ReportBuilder<ReportRecord>(config.Name)
+        ReportBuilder<ReportRecord> builder = new ReportBuilder<ReportRecord>(config.Name)
             .From(source)
             .Columns(columns);
 
         if (config.PageSize is int pageSize)
             builder.WithPageSize(pageSize);
 
-        foreach (var output in outputs)
+        foreach (OutputSpec output in outputs)
             builder.To(output);
-        foreach (var destination in destinations)
+        foreach (DestinationSpec destination in destinations)
             builder.UploadTo(destination);
 
         return builder.Build();
     }
 
     private static IConfigSourceProvider ResolveSource(IServiceProvider services, string type)
     {
-        var provider = services.GetServices<IConfigSourceProvider>()
+        IConfigSourceProvider? provider = services.GetServices<IConfigSourceProvider>()
             .FirstOrDefault(p => string.Equals(p.Type, type, StringComparison.OrdinalIgnoreCase));
         return provider ?? throw new ConfigurationException(
             $"No source provider is registered for type '{type}'. Register an IConfigSourceProvider with that Type.");
     }
 
     private static IWriterFactory ResolveWriter(IServiceProvider services, string format)
     {
-        var factory = services.GetServices<IWriterFactory>()
+        IWriterFactory? factory = services.GetServices<IWriterFactory>()
             .FirstOrDefault(f => string.Equals(f.Format, format, StringComparison.OrdinalIgnoreCase));
         return factory ?? throw new ConfigurationException(
             $"No writer factory is registered for format '{format}'. Register an IWriterFactory with that Format.");
     }
 
     private static IDestinationFactory ResolveDestination(IServiceProvider services, string type)
     {
-        var factory = services.GetServices<IDestinationFactory>()
+        IDestinationFactory? factory = services.GetServices<IDestinationFactory>()
             .FirstOrDefault(f => string.Equals(f.Type, type, StringComparison.OrdinalIgnoreCase));
         return factory ?? throw new ConfigurationException(
             $"No destination factory is registered for type '{type}'. Register an IDestinationFactory with that Type.");

tests/NeoReports.Core.UnitTests/DynamicConfigTests.cs

@@ -44,7 +44,7 @@ public class DynamicConfigTests
     }
     """;
 
-    private static readonly IReportConfigParser Parser = new JsonReportConfigParser();
+    private static readonly JsonReportConfigParser Parser = new();
 
     private static ReportExecutionContext Exec() =>
         new(Guid.NewGuid().ToString("N"), "sales", null, NullLogger.Instance, CancellationToken.None);