Commit 625ed15
authored
fix(ci): drop the CodeQL rule that only ever fires on generated code (#292)
cs/nested-if-statements has fired four times in this repository and every
one was inside System.Text.RegularExpressions source-generator output —
#157/#158 (2026-07-16, QueryBuilder.Pro) and #307/#308 (2026-08-17,
Core). Never once in code anyone wrote.
paths-ignore: **/obj/** was added for exactly this after the first pair
and did not stop the second, which is the part worth recording. For a
compiled language the extractor takes compilation units from the BUILD,
and generator output has no file in the checkout for a path filter to
match: it is reported under a synthetic obj/.../generated/… path that
never existed on disk. A path filter cannot reach it by construction, so
a third variation on the same tweak would have failed the same way.
Excluding the rule instead. It is a maintainability rule, not a security
one; SonarCloud already covers that ground for this repo; and a rule at a
100% false-positive rate across two different source generators will keep
firing every time a generator changes shape. paths-ignore stays — it is
still correct for anything a build genuinely leaves in the checkout.
The two open alerts were dismissed separately at the repository level,
since resolving a finding does not close its alert. Their first
justification said the build output "was never excluded from the CodeQL
paths", which is wrong — it was, since 3f0c0bd; both dismissals were
rewritten to state the real reason.1 parent 145c467 commit 625ed15
2 files changed
Lines changed: 34 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
| 3 | + | |
| 4 | + | |
3 | 5 | | |
4 | 6 | | |
5 | 7 | | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
118 | 118 | | |
119 | 119 | | |
120 | 120 | | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
121 | 138 | | |
122 | 139 | | |
123 | 140 | | |
| |||
0 commit comments