Skip to content

Commit abb4fb7

Browse files
authored
chore(deps): move the Aspire samples to 13.4.6, verified by actually running one (#272)
The last item from the closed Dependabot set (#241-#251), held out of #266 and #267 because 9.5.2 -> 13.4.6 crosses four majors and reads like a framework migration. It is not one. All six AppHosts compile clean on net8.0 with no source changes, no NU warnings and no deprecation warnings: every API the samples use — AddPostgres, WithDataVolume, AddDatabase, AddProject<>, WithReference, WaitFor, WithExternalHttpEndpoints — survived intact. A clean build proves nothing about an orchestrator, so sample 10 was actually run, both ways the docs offer: `dotnet run --project .../AppHost` and the new `aspire run` CLI. Both bring the Postgres container up (~10-25s) and connect it to the session network. The documented workflow is unchanged; the CLI is an addition, not a replacement. Two real findings from running it: - The default PostgreSQL image moved from 17.6 to 18.3 with the Aspire version. Sample 10's header comment asserted "postgres:17", which was now false; it no longer names a tag it does not control. The READMEs' `docker run ... postgres:17` lines are untouched — those describe running Postgres yourself as an alternative to Aspire, and remain accurate. - `aspire run` writes an `aspire.config.json` pinned to whichever AppHost ran last. With six in this repo, committing it would tie everyone to one sample, so it is gitignored. Full solution rebuilt with --no-incremental; Core 303, Jobs 39, AspNetCore 159, UI 245.
1 parent 74ffea0 commit abb4fb7

9 files changed

Lines changed: 17 additions & 12 deletions

File tree

.gitignore

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -93,3 +93,7 @@ neoreports-schedules/
9393

9494
# Generated by the Web SDK for the E2E test host; it is never launched, only hosted in-process.
9595
tests/NeoReports.WebUi.E2ETests/Properties/launchSettings.json
96+
97+
# Generated by the Aspire CLI (`aspire run`) and pinned to whichever AppHost ran last — this repo
98+
# has six of them, so committing it would tie everyone to one sample.
99+
aspire.config.json

build/Directory.Packages.props

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -59,11 +59,11 @@
5959
<!-- Samples / Aspire (Epic H) — 9.5.2 is the last Aspire line targeting net8.0/net9.0;
6060
Aspire 13.x's AppHost SDK forces net10.0, which would be inconsistent with every other
6161
runnable sample and every runtime this repo otherwise ships/tests against. -->
62-
<PackageVersion Include="Aspire.Hosting.AppHost" Version="9.5.2" />
63-
<PackageVersion Include="Aspire.Hosting.PostgreSQL" Version="9.5.2" />
64-
<PackageVersion Include="Aspire.Hosting.MySql" Version="9.5.2" />
65-
<PackageVersion Include="Aspire.Hosting.SqlServer" Version="9.5.2" />
66-
<PackageVersion Include="Aspire.Hosting.MongoDB" Version="9.5.2" />
62+
<PackageVersion Include="Aspire.Hosting.AppHost" Version="13.4.6" />
63+
<PackageVersion Include="Aspire.Hosting.PostgreSQL" Version="13.4.6" />
64+
<PackageVersion Include="Aspire.Hosting.MySql" Version="13.4.6" />
65+
<PackageVersion Include="Aspire.Hosting.SqlServer" Version="13.4.6" />
66+
<PackageVersion Include="Aspire.Hosting.MongoDB" Version="13.4.6" />
6767
</ItemGroup>
6868

6969
</Project>

samples/10-aspire-postgres-wide/AppHost/AppHost.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,8 @@
77
// starting that UI; everything else (running "wide-transactions", watching progress,
88
// downloading the file) happens by clicking through it.
99
//
10-
// No manual setup: Aspire pulls the postgres:17 image, starts the container, and injects the
10+
// No manual setup: Aspire pulls the PostgreSQL image it defaults to (the tag moves with the Aspire
11+
// version — it is 18.x on 13.4), starts the container, and injects the
1112
// connection string into the web host via WithReference — the same "docker compose up, but typed
1213
// and orchestrated from C#" experience Aspire is built for.
1314

samples/10-aspire-postgres-wide/AppHost/NeoReports.Samples.AspirePostgresWide.AppHost.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<Project Sdk="Microsoft.NET.Sdk">
22

3-
<Sdk Name="Aspire.AppHost.Sdk" Version="9.5.2" />
3+
<Sdk Name="Aspire.AppHost.Sdk" Version="13.4.6" />
44

55
<PropertyGroup>
66
<OutputType>Exe</OutputType>

samples/11-aspire-mysql-wide/AppHost/NeoReports.Samples.AspireMySqlWide.AppHost.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<Project Sdk="Microsoft.NET.Sdk">
22

3-
<Sdk Name="Aspire.AppHost.Sdk" Version="9.5.2" />
3+
<Sdk Name="Aspire.AppHost.Sdk" Version="13.4.6" />
44

55
<PropertyGroup>
66
<OutputType>Exe</OutputType>

samples/12-aspire-sqlserver-wide/AppHost/NeoReports.Samples.AspireSqlServerWide.AppHost.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<Project Sdk="Microsoft.NET.Sdk">
22

3-
<Sdk Name="Aspire.AppHost.Sdk" Version="9.5.2" />
3+
<Sdk Name="Aspire.AppHost.Sdk" Version="13.4.6" />
44

55
<PropertyGroup>
66
<OutputType>Exe</OutputType>

samples/13-aspire-mongodb-wide/AppHost/NeoReports.Samples.AspireMongoDbWide.AppHost.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<Project Sdk="Microsoft.NET.Sdk">
22

3-
<Sdk Name="Aspire.AppHost.Sdk" Version="9.5.2" />
3+
<Sdk Name="Aspire.AppHost.Sdk" Version="13.4.6" />
44

55
<PropertyGroup>
66
<OutputType>Exe</OutputType>

samples/14-aspire-all-sources-demo/AppHost/NeoReports.Samples.AspireAllSourcesDemo.AppHost.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<Project Sdk="Microsoft.NET.Sdk">
22

3-
<Sdk Name="Aspire.AppHost.Sdk" Version="9.5.2" />
3+
<Sdk Name="Aspire.AppHost.Sdk" Version="13.4.6" />
44

55
<PropertyGroup>
66
<OutputType>Exe</OutputType>

samples/15-aspire-pro-demo/AppHost/NeoReports.Samples.AspireProDemo.AppHost.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<Project Sdk="Microsoft.NET.Sdk">
22

3-
<Sdk Name="Aspire.AppHost.Sdk" Version="9.5.2" />
3+
<Sdk Name="Aspire.AppHost.Sdk" Version="13.4.6" />
44

55
<PropertyGroup>
66
<OutputType>Exe</OutputType>

0 commit comments

Comments
 (0)