Make privacy and terms footer links go to tb.pro (#804)

Author: davinotdavid

assets/app/vue/components/FooterBar.vue

@@ -3,6 +3,7 @@ import { computed, ref } from 'vue';
 import { useI18n } from 'vue-i18n';
 import { useRoute } from 'vue-router';
 import { StandardFooter } from '@thunderbirdops/services-ui';
+import { TERMS_OF_SERVICE_URL, PRIVACY_POLICY_URL } from '@/defines';
 
 const { t } = useI18n();
 
@@ -71,15 +72,15 @@ const logoSrc = computed(() => {
     </template>
 
     <template #privacyPolicy>
-      <router-link to="/privacy">
+      <a :href="PRIVACY_POLICY_URL" target="_blank">
         {{ t('footer.privacyPolicy') }}
-      </router-link>
+      </a>
     </template>
 
     <template #legal>
-      <router-link to="/terms">
+      <a :href="TERMS_OF_SERVICE_URL" target="_blank">
         {{ t('footer.legal') }}
-      </router-link>
+      </a>
     </template>
   </standard-footer>
 </template>

assets/app/vue/defines.ts

@@ -6,4 +6,6 @@ export const WHAT_IS_SMTP_SUPPORT_URL = 'https://support.tb.pro/hc/articles/4610
 export const DOWNLOAD_THUNDERBIRD_DESKTOP_URL = 'https://www.thunderbird.net/thunderbird/all?utm_campaign=main&utm_medium=tb_pro&utm_source=thundermail_dashboard&utm_content=desktop_download';
 export const DOWNLOAD_THUNDERBIRD_MOBILE_URL = 'https://play.google.com/store/apps/details?id=net.thunderbird.android&referrer=utm_campaign%3Dmain%26utm_medium%3Dtb_pro%26utm_source%3Dthundermail_dashboard%26utm_content%3Dmobile_download';
 export const IOS_SUPPORT_URL = 'https://support.tb.pro/hc/en-us/articles/51053665815827-Setting-Up-Thundermail-on-iOS';
-export const STATUS_PAGE_URL = 'https://status.tb.pro/';
+export const STATUS_PAGE_URL = 'https://status.tb.pro/';
+export const TERMS_OF_SERVICE_URL = 'https://tb.pro/terms/';
+export const PRIVACY_POLICY_URL = 'https://tb.pro/privacy/';

assets/app/vue/router.ts

@@ -4,9 +4,7 @@ import { createRouter, createWebHistory, RouteRecordRaw } from 'vue-router';
 import DashboardView from '@/views/DashboardView/index.vue';
 import ManageMfaView from '@/views/ManageMfaView/index.vue';
 import PrivacyAndDataView from '@/views/PrivacyAndDataView.vue';
-import PrivacyView from '@/views/PrivacyView.vue';
 import SubscribeView from '@/views/SubscribeView/index.vue';
-import TermsView from '@/views/TermsView.vue';
 import TosPrivacyView from '@/views/TosPrivacyView/index.vue';
 
 // Thundermail Routes
@@ -87,23 +85,6 @@ const routes: RouteRecordRaw[] = window._page?.isErrorPage ? [
     name: 'mail-security-settings',
     component: SecuritySettingsView,
   },
-  // Footer links (shared between Accounts and Thundermail)
-  {
-    path: '/privacy',
-    name: 'privacy',
-    component: PrivacyView,
-    meta: {
-      isPublic: true,
-    },
-  },
-  {
-    path: '/terms',
-    name: 'terms',
-    component: TermsView,
-    meta: {
-      isPublic: true,
-    },
-  },
   // Sign Up / Subscribe
   {
     path: '/subscribe',