Fix Jenkins operator reporting invalid URLs with build number 0 (#23)

* Initial plan

* Fix Jenkins operator to skip status update when build number is 0

Co-authored-by: wuhuizuo <2574558+wuhuizuo@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: wuhuizuo <2574558+wuhuizuo@users.noreply.github.com>

Author: Copilot

pkg/jenkins/controller.go

@@ -365,6 +365,12 @@ func (c *Controller) syncPendingJob(pj prowapi.ProwJob, reports chan<- prowapi.P
 		case jb.IsRunning():
 			// Build still going.
 			c.incrementNumPendingJobs(pj.Spec.Job)
+			// Do not update the commit status when build number is 0.
+			// Build number 0 indicates the Jenkins job hasn't been properly assigned a build number yet.
+			if jb.Number == 0 {
+				c.log.WithFields(pjutil.ProwJobFields(&pj)).Debug("Skipping status update for build with number 0")
+				return nil
+			}
 			if pj.Status.Description == "Jenkins job running." && pj.Status.URL != "" {
 				return nil
 			}
@@ -452,6 +458,12 @@ func (c *Controller) syncTriggeredJob(pj prowapi.ProwJob, reports chan<- prowapi
 		// Still in queue.
 		pj.Status.Description = "Jenkins job enqueued."
 	} else if jb.IsRunning() {
+		// Do not update the commit status when build number is 0.
+		// Build number 0 indicates the Jenkins job hasn't been properly assigned a build number yet.
+		if jb.Number == 0 {
+			c.log.WithFields(pjutil.ProwJobFields(&pj)).Debug("Skipping status update for build with number 0")
+			return nil
+		}
 		// If a Jenkins build already exists for this job, advance the ProwJob to Pending and
 		// it should be handled by syncPendingJob in the next sync.
 		if pj.Status.PendingTime == nil {

pkg/jenkins/controller_test.go

@@ -295,6 +295,28 @@ func TestSyncTriggeredJobs(t *testing.T) {
 			expectedEnqueued:    true,
 			expectedPendingTime: nil,
 		},
+		{
+			name: "running job with build number 0, should not report",
+			pj: prowapi.ProwJob{
+				ObjectMeta: metav1.ObjectMeta{
+					Name:      "zerobuild",
+					Namespace: "prowjobs",
+				},
+				Spec: prowapi.ProwJobSpec{
+					Type: prowapi.PostsubmitJob,
+				},
+				Status: prowapi.ProwJobStatus{
+					State: prowapi.TriggeredState,
+				},
+			},
+			builds: map[string]Build{
+				"zerobuild": {enqueued: false, Number: 0},
+			},
+			expectedBuild:       false,
+			expectedReport:      false,
+			expectedState:       prowapi.TriggeredState,
+			expectedPendingTime: nil,
+		},
 	}
 	for _, tc := range testcases {
 		totServ := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
@@ -526,6 +548,26 @@ func TestSyncPendingJobs(t *testing.T) {
 			expectedComplete: true,
 			expectedReport:   true,
 		},
+		{
+			name: "building with build number 0, should not report",
+			pj: prowapi.ProwJob{
+				ObjectMeta: metav1.ObjectMeta{
+					Name:      "zerobuild",
+					Namespace: "prowjobs",
+				},
+				Spec: prowapi.ProwJobSpec{
+					Job: "test-job",
+				},
+				Status: prowapi.ProwJobStatus{
+					State: prowapi.PendingState,
+				},
+			},
+			builds: map[string]Build{
+				"zerobuild": {enqueued: false, Number: 0},
+			},
+			expectedState:  prowapi.PendingState,
+			expectedReport: false,
+		},
 	}
 	for _, tc := range testcases {
 		t.Logf("scenario %q", tc.name)